From 61191e15ba4aee6c1ca246b64909401336348827 Mon Sep 17 00:00:00 2001 From: Andrew Stein Date: Mon, 12 Nov 2018 02:15:30 -0500 Subject: [PATCH 1/3] Fixed webpack-plugin issue with local babel-loader --- CHANGELOG.md | 4 ++++ examples/webpack/in.js | 1 + examples/webpack/package.json | 3 ++- packages/perspective/webpack-plugin.js | 5 ++++- 4 files changed, 11 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index ba67b0b1b9..2ab1cf22fc 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,9 @@ # Changelog +## [0.2.5] - 2018-11-09 +### Fixes +* [#301](https://github.com/jpmorganchase/perspective/pull/301) Fixed missing `webpack-plugin` export and `babel-polyfill` import. + ## [0.2.4] - 2018-11-08 ### Added * [#299](https://github.com/jpmorganchase/perspective/pull/299) Added a new Menu bar (accessible via right-click on the config button) for `reset`, `copy` and `download` actions, and an API for `download()` (`copy()` and `reset()` already exist). diff --git a/examples/webpack/in.js b/examples/webpack/in.js index c20e4dc821..fc6912596a 100644 --- a/examples/webpack/in.js +++ b/examples/webpack/in.js @@ -8,6 +8,7 @@ */ const perspective = require("@jpmorganchase/perspective").default; +require("@jpmorganchase/perspective-viewer"); const table = perspective.worker().table([{x: 1}]); table.view().to_json(console.log); diff --git a/examples/webpack/package.json b/examples/webpack/package.json index 169f454a00..3f133cba8d 100644 --- a/examples/webpack/package.json +++ b/examples/webpack/package.json @@ -10,6 +10,7 @@ "keywords": [], "license": "Apache-2.0", "dependencies": { - "@jpmorganchase/perspective": "^0.2.5" + "@jpmorganchase/perspective": "^0.2.5", + "@jpmorganchase/perspective-viewer": "^0.2.5" } } diff --git a/packages/perspective/webpack-plugin.js b/packages/perspective/webpack-plugin.js index 2fc497b033..e7bcf2bae2 100644 --- a/packages/perspective/webpack-plugin.js +++ b/packages/perspective/webpack-plugin.js @@ -11,6 +11,8 @@ const WORKER_LOADER_PATH = require.resolve("./src/loader/file_worker_loader"); const WASM_LOADER_PATH = require.resolve("./src/loader/cross_origin_file_loader.js"); const BLOB_LOADER_PATH = require.resolve("./src/loader/blob_worker_loader.js"); +const BABEL_CONFIG = require("./babel.config.js"); + class PerspectiveWebpackPlugin { constructor(options = {}) { this.options = options; @@ -63,7 +65,8 @@ class PerspectiveWebpackPlugin { test: /\.js$/, include: load_path, exclude: /node_modules\/(?!(\@apache|\@jupyterlab))|psp\.(asmjs|async|sync)\.js/, - loader: "babel-loader" + loader: "babel-loader", + options: BABEL_CONFIG }); rules.push({ From c275d6cafe8d3a57fc7551f4ee5808587ba24f4e Mon Sep 17 00:00:00 2001 From: Andrew Stein Date: Mon, 12 Nov 2018 02:15:56 -0500 Subject: [PATCH 2/3] Fixed shadow-dom resize bug --- packages/perspective-viewer/src/js/view.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/perspective-viewer/src/js/view.js b/packages/perspective-viewer/src/js/view.js index 2c14178d4a..1276167fcd 100755 --- a/packages/perspective-viewer/src/js/view.js +++ b/packages/perspective-viewer/src/js/view.js @@ -467,7 +467,7 @@ class View extends ViewPrivate { this.shadowRoot.querySelector("#app").classList.remove("columns_horizontal"); } - if (!document.hidden && this.offsetParent && document.contains(this)) { + if (!document.hidden && this.offsetParent) { this._plugin.resize.call(this); } } From c668996be953a75ae30d5c9a7acfb1872ac03ed5 Mon Sep 17 00:00:00 2001 From: Andrew Stein Date: Mon, 12 Nov 2018 02:18:16 -0500 Subject: [PATCH 3/3] Fixed shadow-dom Material dark theme issue --- packages/perspective-viewer/src/less/default.less | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/perspective-viewer/src/less/default.less b/packages/perspective-viewer/src/less/default.less index e3002359c6..c6cb44e064 100644 --- a/packages/perspective-viewer/src/less/default.less +++ b/packages/perspective-viewer/src/less/default.less @@ -346,7 +346,7 @@ } #drop_target { - background: white; + background: var(--plugin--background, #fff); } #drop_target_inner h3 {