Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to do internationalization or change to chinese ui please? #1934

Closed
markqiu opened this issue Aug 4, 2022 · 4 comments
Closed

how to do internationalization or change to chinese ui please? #1934

markqiu opened this issue Aug 4, 2022 · 4 comments
Labels
enhancement Feature requests or improvements question Questions about use, potential features, or improvements

Comments

@markqiu
Copy link

markqiu commented Aug 4, 2022

how to do internationalization or change to chinese ui please?

@texodus
Copy link
Member

texodus commented Aug 4, 2022

Perspective is currently only internationalized for the en-us locale. The UI is already uses fully parameterized labels, so new UI locales can mostly be added via CSS example; the UI should already support locale-determined number and datetime data representations, as well as full utf-8 support for string columns.

I'd merge a pull request adding chinese parameterized labels as in the above example, the type labels may require some creativity in other languages (particularly datetime mdy and boolean t/f).

@markqiu
Copy link
Author

markqiu commented Aug 5, 2022

A merge request like this is exactly what I need, or I am also willing to submit an MR like this.

@timkpaine timkpaine added enhancement Feature requests or improvements question Questions about use, potential features, or improvements labels Aug 27, 2022
@aswfilip
Copy link

Hello!
I would also like to contribute to the internationalization of Perspective. @texodus Can you please point me in the right direction? Link for the example no longer works. Thank you!

@texodus
Copy link
Member

texodus commented Jul 5, 2024

Internationalization support was added in #2565

@texodus texodus closed this as completed Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests or improvements question Questions about use, potential features, or improvements
Projects
None yet
Development

No branches or pull requests

4 participants