You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The correct datetime filter being applied to the view.
Actual Result:
Various issues:
The input format of the datetime is inconsistent; one cannot filter using the exact datetime string as displayed in the grid, and there are no error messages to help determine the correct format.
When the datetime is input in a correct format, the filter doesn't work because the == match does not work. Using > or < comparators work okay, but also not as expected as ">" on an exact datetime value (with date, and time) doesn't actually exclude the value it matches.
In a PerspectiveWidget with server=True, the filtering works as intended:
But not when the PerspectiveWidget is in default distributed mode:
This leads me to believe this is an issue either in the make_filter_term code in emscripten.cpp and in the Javascript date parser itself; the former influences how a Date in JS is transformed into a Unix timestamp for internal conversion, and it is clear that the correct timestamp does filter correctly in the core engine (as demonstrated by server mode PerspectiveWidget), and the latter influences what formats of dates are accepted.
Some suggestions:
Fix the filter handling in Javascript - the issue should be in make_filter_term where it handles the conversion to Unix timestamp for DTYPE_DATE and DTYPE_TIME
Make the filter UI more intuitive for datetimes/provide a single, correct format in an error message that the user can use to rewrite their filter config
Make the JS date parser more lenient in terms of formatting
More comprehensive viewer tests for filtering, as this seems to be a JS-specific issue
Environment:
Latest master.
The text was updated successfully, but these errors were encountered:
Bug Report
Steps to Reproduce:
Expected Result:
The correct datetime filter being applied to the view.
Actual Result:
Various issues:
==
match does not work. Using>
or<
comparators work okay, but also not as expected as ">" on an exact datetime value (with date, and time) doesn't actually exclude the value it matches.In a
PerspectiveWidget
withserver=True
, the filtering works as intended:But not when the
PerspectiveWidget
is in default distributed mode:This leads me to believe this is an issue either in the
make_filter_term
code inemscripten.cpp
and in the Javascript date parser itself; the former influences how aDate
in JS is transformed into a Unix timestamp for internal conversion, and it is clear that the correct timestamp does filter correctly in the core engine (as demonstrated by server modePerspectiveWidget
), and the latter influences what formats of dates are accepted.Some suggestions:
make_filter_term
where it handles the conversion to Unix timestamp forDTYPE_DATE
andDTYPE_TIME
Environment:
Latest master.
The text was updated successfully, but these errors were encountered: