repo contains 107 files with windows CRLF line endings

[jspillers]

Bug Report

There are 107 files in the repo that contain CRLF line endings as opposed to LF.

Steps to Reproduce:

1. cd perspective
2. find . | grep -v dist | grep -v node_modules | xargs file | grep 'CRLF' | sed 's/:.*$//'

Expected Result:

above one-liner should return zero lines

Actual Result:

it returns 107 files with windows line endings

[MisterAwesome23]

Hello. I am new to perspective and would love to contribute.
I would like to fix this issue, if no one is already on it.

windows line endings

If I got this right- there are 107 files ending with "\r\n" instead of a "\n"
More on this here
So we need files ending in the unix format of a "\n" right?

[timkpaine]

@MisterAwesome23 correct

[MisterAwesome23]

I've replaced all the ending by unix endings now.

find . | grep -v dist | grep -v node_modules | xargs file | grep 'CRLF' | sed 's/:.*$//'

This now results in 0 files.

Link to entire changes-
https://pastebin.com/A7Pjn3wB

Creating a pull for this.
#1032

"we require a CLA for the following people : (@MisterAwesome23)"
Can someone guide me to be added to CLA so this pull can be merged?

[texodus]

Thanks for the report!

We've gotten a few "ctrl-f" style fixes for this, so it's worth clarifying what we would consider a proper fix for this issue. It's not quite enough to simply remove the CRLF characters - we don't want future ones committed either.

Our linter ESLint supports linebreak-style and the documentation indicates this should be set to \n by default. It is clearly not working - but we should find out why and fix it, then this will be asserted as a git hook via yarn lint, preventing future commits from containing bad characters, and the existing errors can be trivially repaired with yarn fix (which will prevent any PRs for this meeting copious merge conflicts).

[darjama]

I've submitted a pull request #1075 to modify the eslint settings and change the .gitattributes file so that .js files aren't altered to have CRLF line endings on checkout on a windows machine as documented here.

The pull request doesn't change the existing files, and at least on my machine using eslint --stdin --fix brings my processor to its knees with so many changes. It works if I go directory by directory though. This tool for VSCode is helpful for batching the changes for all files.
I've submitted an ICLA.

[darjama]

Also, some additional configuration on windows machines might be needed to avoid it overall: https://warlord0blog.wordpress.com/2019/09/04/vscode-crlf-vs-lf-battle/

[texodus]

Thanks @darjama, I think #1078 covers this perfectly!