From 3411262541e7860f125bf442a5a9b464b6cfb898 Mon Sep 17 00:00:00 2001 From: Tim Paine Date: Wed, 18 Apr 2018 16:10:56 -0400 Subject: [PATCH 1/2] comm is a promise now, upping version --- packages/perspective-jupyterlab/package.json | 6 +++--- packages/perspective-jupyterlab/src/ts/index.ts | 17 +++++++++-------- 2 files changed, 12 insertions(+), 11 deletions(-) diff --git a/packages/perspective-jupyterlab/package.json b/packages/perspective-jupyterlab/package.json index f67f317097..3bb4ab6f41 100644 --- a/packages/perspective-jupyterlab/package.json +++ b/packages/perspective-jupyterlab/package.json @@ -1,6 +1,6 @@ { "name": "@jpmorganchase/perspective-jupyterlab", - "version": "0.1.8", + "version": "0.1.9", "description": "Perspective.js", "files": [ "build/*.d.ts", @@ -27,9 +27,9 @@ "@jpmorganchase/perspective-viewer": "^0.1.8", "@jpmorganchase/perspective-viewer-highcharts": "^0.1.8", "@jpmorganchase/perspective-viewer-hypergrid": "^0.1.8", - "@jupyterlab/application": "^0.15.0", + "@jupyterlab/application": "^0.16.0", "@jupyterlab/rendermime-interfaces": "^1.0.0", - "@jupyterlab/services": "^1.1.1-0", + "@jupyterlab/services": "^2.0.0", "@phosphor/messaging": "^1.2.2", "@phosphor/widgets": "^1.5.0", "@types/socket.io-client": "^1.4.0", diff --git a/packages/perspective-jupyterlab/src/ts/index.ts b/packages/perspective-jupyterlab/src/ts/index.ts index 78721444b6..cb8b924c47 100644 --- a/packages/perspective-jupyterlab/src/ts/index.ts +++ b/packages/perspective-jupyterlab/src/ts/index.ts @@ -93,14 +93,15 @@ export class RenderedPSP extends Widget implements IRenderMime.IRenderer { if (sessionModels[i].kernel.id === kernelId) { Session.connectTo(sessionModels[i]).then(session => { - let comm = session.kernel.connectToComm(name + '/' + channel); - comm.open('ack'); - comm.onMsg = (msg: any) => { - let dat = msg['content']['data']; - let tmp = JSON.parse(dat); - psp.update(tmp); - }; - comm.onClose = (msg: any) => {}; + session.kernel.connectToComm(name + '/' + channel).then(comm => { + comm.open('ack'); + comm.onMsg = (msg: any) => { + let dat = msg['content']['data']; + let tmp = JSON.parse(dat); + psp.update(tmp); + }; + comm.onClose = (msg: any) => {}; + }); }); } From 588e52afe78740e2347fd3710cad372abc45bcaa Mon Sep 17 00:00:00 2001 From: Tim Paine Date: Thu, 19 Apr 2018 17:24:08 -0400 Subject: [PATCH 2/2] . --- packages/perspective-jupyterlab/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/perspective-jupyterlab/package.json b/packages/perspective-jupyterlab/package.json index 3bb4ab6f41..92afbf7dfa 100644 --- a/packages/perspective-jupyterlab/package.json +++ b/packages/perspective-jupyterlab/package.json @@ -1,6 +1,6 @@ { "name": "@jpmorganchase/perspective-jupyterlab", - "version": "0.1.9", + "version": "0.1.8", "description": "Perspective.js", "files": [ "build/*.d.ts",