Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add rule to enforce initialization of static properties #557

Open
ajafff opened this issue Feb 25, 2019 · 1 comment · May be fixed by #734
Open

add rule to enforce initialization of static properties #557

ajafff opened this issue Feb 25, 2019 · 1 comment · May be fixed by #734
Labels
good first issue help wanted rule suggestion

Comments

@ajafff
Copy link
Member

ajafff commented Feb 25, 2019

strictPropertyInitialization only works with instance properties. The proposed rule would enforce every static property (except for ambient declarations) whose type doesn't allow undefined to have an initializer.

declare class C {
  static P: string; // ok, ambient declaration
}
class D {
  static P: string; // missing initializer
}

class E {
  static P = ''; // ok
}

class F {
  static P: string | undefined; // ok, allows 'undefined'
  static Q: any; // ok, allows 'undefined'
  static R: unknown; // ok, allows 'undefined'
}
@ajafff
Copy link
Member Author

ajafff commented Jun 21, 2019

Upstream issue: microsoft/TypeScript#27899

ajafff added a commit that referenced this issue Dec 6, 2020
@ajafff
new rule: initialize-static-property
1bea9c1 
Fixes: #557
@ajafff ajafff linked a pull request Dec 16, 2020 that will close this issue
new rule: prefer-spread-arguments #710
Open
3 tasks
@ajafff ajafff removed a link to a pull request Dec 16, 2020
new rule: prefer-spread-arguments #710
Open
3 tasks
@ajafff ajafff linked a pull request Jan 6, 2021 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted rule suggestion
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

new rule: initialize-static-property fimbullinter/wotan
1 participant
@ajafff