Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions for using specific bazel-bats source releases #25

Open
filmil opened this issue Oct 27, 2023 · 3 comments
Open

Add instructions for using specific bazel-bats source releases #25

filmil opened this issue Oct 27, 2023 · 3 comments
Labels
good first issue Good for newcomers
Milestone

Comments

@filmil
Copy link
Owner

filmil commented Oct 27, 2023

At the moment, README.md contains only the instructions on how to use top-of-tree code.

We should add instructions for using specific source releases too.

@filmil filmil added the good first issue Good for newcomers label Oct 27, 2023
@filmil filmil added this to the v0.33.x milestone Oct 27, 2023
@pfiaux
Copy link

pfiaux commented Apr 12, 2024

We're using something a like that:

BAZEL_BATS_VERSION = "0.33.0"
BAZEL_BATS_SHA256 = "916a3e9ec2d2a9d196b84fa5ae2251a06acf891952df2134c10fe5314a8bbabc"

http_archive(
    name = "bazel_bats",
    sha256 = BAZEL_BATS_SHA256,
    strip_prefix = "bazel-bats-%s" % BAZEL_BATS_VERSION,
    url = "https://github.com/filmil/bazel-bats/archive/refs/tags/v%s.tar.gz" % BAZEL_BATS_VERSION,
)

load("@bazel_bats//:deps.bzl", "bazel_bats_dependencies")

bazel_bats_dependencies()

Would that work or do you have something else in mind?

@filmil
Copy link
Owner Author

filmil commented Apr 12, 2024

What I mean is, for example, that release notes should contain the correct instructions for bringing in that specific version.

@pfiaux
Copy link

pfiaux commented Apr 22, 2024

Ah I see, so for example rules_go has some automation/rules to handle that https://github.com/bazelbuild/rules_go/wiki/Release-process. I'm sure other rules also use a similar solution, maybe there's a tool some project shared for that.

So something similar so that when you do a release there's an easy way to generate the text to append/prepend to the release notes when the release is done with gh (I saw that notes can be passed in to gh release https://cli.github.com/manual/gh_release_edit)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants