Option to configure link target overrides resets when opening about:preferences

[filips123]

Description

Option to configure link target overwrites (When opening a link that should normally open in a new window or tab) resets to the default value when the user opens about:preferences.

Steps to Reproduce

1. Go to about:preferences (Firefox settings page)
2. Set "When opening a link that should normally open in a new window or tab" to "Do not change link behaviour"
3. Close and reopen about:preferences
4. Observe that the option has been reset to the default value

Additional Information

The issue is caused by this code which is run every time about:preferences is opened, overwriting user-set preference:

https://github.com/filips123/FirefoxPWA/blob/45986aa29386794a3a354bca8395455dfa0cd9cb/native/userchrome/profile/chrome/pwa/content/preferences.jsm#L77-L83

The solution is to only run this code when the user changes "Open out of scope URLs in a default browse". I will fix this soon in the next update.

[filips123]

This has been fixed in v1.2.2.