Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web apps broken in Firefox 124 #475

Closed
thecimot opened this issue Mar 19, 2024 · 21 comments
Closed

Web apps broken in Firefox 124 #475

thecimot opened this issue Mar 19, 2024 · 21 comments
Labels
bug Something isn't working
Milestone

Comments

@thecimot
Copy link

Additional Information

Affected Websites

  • all website
  • ...

Environment

System Details Report


Report details

  • Date generated: 2024-03-20 01:05:41

Hardware Information:

  • Hardware Model: Lenovo IdeaPad 3 14IML05
  • Memory: 12,0 GiB
  • Processor: Intel® Core™ i3-10110U × 4
  • Graphics: Intel® UHD Graphics (CML GT2)
  • Disk Capacity: 1,3 TB

Software Information:

  • Firmware Version: DXCN45WW
  • OS Name: Ubuntu 23.10
  • OS Build: (null)
  • OS Type: 64-bit
  • GNOME Version: 45.2
  • Windowing System: Wayland
  • Kernel Version: Linux 6.5.0-26-generic
  • Installation method: Deb

  • Extension version: 2.10.1

  • Native version: 2.10.1

  • Runtime version: 124.0

  • Firefox version: 124.0

Screenshot from 2024-03-20 00-57-39

@thecimot thecimot added the bug Something isn't working label Mar 19, 2024
@filips123
Copy link
Owner

Firefox 124 broke something... I will try to fix this soon.

@filips123 filips123 changed the title Firefox pwa Apps Blank Screen Web apps broken in Firefox 124 Mar 19, 2024
@filips123 filips123 pinned this issue Mar 19, 2024
@filips123 filips123 moved this to To Do in PWAsForFirefox Mar 19, 2024
@hofleverancier
Copy link

FIY I'm on Fedora with firefox-123.0.1-1.fc39.x86_64 and are also having this exact problem since today.

@hofleverancier
Copy link

Possibly there is something else happening. My Fedora install with Firefox 123 has this issue since today, downgrading Firefox to 119 did not fix the problem. Using non-flatpak'd Firefox.

@filips123
Copy link
Owner

Firefox used for PWAs is separate from your main Firefox, so it has probably already updated to 124.

@github-project-automation github-project-automation bot moved this from To Do to Done in PWAsForFirefox Mar 19, 2024
@filips123 filips123 added this to the 2.11.0 milestone Mar 19, 2024
@filips123
Copy link
Owner

filips123 commented Mar 19, 2024

This should be fixed in https://github.com/filips123/PWAsForFirefox/releases/tag/v2.11.0. Please make sure the native part is updated to that release 2.11.1, and then run "Patch profiles and runtime" from the extension settings.

@Quasar-Kim
Copy link

Note for those experiencing the issue even after the update: I updated the native runtime to 2.11.0 but PWAs were not working. I pressed alt > help > about firefox to see the firefox version, then firefox update itself from 123 to 124, which resolved the issue!

@filips123
Copy link
Owner

Oh, I think the fix breaks web apps on Firefox before 124... I will also try to fix this.

@filips123
Copy link
Owner

I restored compatibility with Firefox before 124 in https://github.com/filips123/PWAsForFirefox/releases/tag/v2.11.1. So, it should now be compatible with all recent Firefox versions.

@botkero
Copy link

botkero commented Mar 20, 2024

I still have a blank window. I don't know what I'm doing wrong. I also got the banner which advised me to update, but I thought I had done it.
Any help?

Project versions:

    Extension version: 2.11.1
    Native version: 2.10.1
    Runtime version: 124.0
    Firefox version: 124.0

@filips123
Copy link
Owner

You also need to update the native version to 2.11.1. Which OS are you on?

@botkero
Copy link

botkero commented Mar 20, 2024

You also need to update the native version to 2.11.1. Which OS are you on?

Windows, but I fixed it. It seems that the installer did not recognize my current installation and installed itself somewhere else. I did not notice this immediately, but now everything works.

@filips123
Copy link
Owner

It seems that the installer did not recognize my current installation and installed itself somewhere else.

That is known issue (#268), but I don't know how to fix it.

@user9713
Copy link

I'm experiencing this issue and I've followed all the steps in this bug report. Any advice on how to fix it?

@filips123
Copy link
Owner

Please check the versions listed in "About project" in the extension settings, and the version with firefoxpwa --version. Are the native version from settings and the version reported by the command both 2.11.1?

If they are, run "Patch profiles and runtime" from the extension settings. Also, please try to install a new PWA into a new profile and check if it works.

If the versions are different, you might also have the problem with the installer. Go to the control panel or settings and uninstall PWAsForFirefox, then reinstall it. Then, check the versions again and try the above steps again.

@elpollitodiablo
Copy link

Ok so I was having the same issues. What I've tried:

  • Verified Firefox Version to be 124
  • Verified that the browser extension is 2.11.1
  • Verified the native extension is 2.11.1
  • Used "Patch profiles and runtime"
  • Used "reinstall runtime"
  • Reinstalled the native extension completely
  • Installed a PWA in a new profile
  • Multiple restarts of browser and system

I'm on Windows 11 version 23H2 using chocolatey package manager to manage firefoxpwa

@elpollitodiablo
Copy link

elpollitodiablo commented Mar 25, 2024

Ok I fixed it.

For some reason I had a Firefox PWA extension installed in my AppData directory C:\Users\***\AppData\Local\Programs\FirefoxPWA which was used by the Firefox extension (and stuck at 2.8.0!). Chocolatey however installed it in C:\Program Files\FirefoxPWA

First I checked my PATH and the account PATH was referencing the AppData version and the system PATH was referencing the Program Files version (or the other way around, I forgot). So I updated the PATH variable to use the Program Files version, which did nothing (or maybe I should have done a reboot, but I'm lazy and frustrated). So I renamed the folder PWA in my AppData, which broke the browser extension. It did not recognize the native extension anymore. That made it clear that the browser extension seems hard wired to the installation in AppData.

Long story short: I copied everything from Program Files to the AppData directory of forefoxpwa and, lo and behold, it works.

@filips123 maybe there should be an option in the browser extension to set where the native layer is located.

Hope this helps anyone.

@AxelTerizaki
Copy link

Hello.

I'm having the same issue. I tried creating new pwas with a new profile but to no avail.

I have Firefox 124.0.1 on Windows and the extension is at version 2.11.1

Is there something I'm missing? What's the native version? How do I check the version or update it?

@filips123
Copy link
Owner

maybe there should be an option in the browser extension to set where the native layer is located.

@elpollitodiablo

This isn't possible.

Firefox just looks at the specific registry keys to see where the native connector is installed. It checks per-user (HKCU\SOFTWARE\Mozilla\NativeMessagingHosts\firefoxpwa) and a global key (HKLM\SOFTWARE\Mozilla\NativeMessagingHosts\firefoxpwa), and (I think) the per-user key has priority over the other one. This is unrelated to the PATH variable.

The problem is that the installer doesn't detect if you've previously installed it per-user or per-machine, so if you then choose a different option, you will have two installations, but Firefox will use only the per-user one (which might be outdated).

I'm having the same issue. I tried creating new pwas with a new profile but to no avail.

@AxelTerizaki

Check in the Windows settings or control panel if you have multiple PWAsForFirefox installations listed, and remove them. You can also check if the above registry keys exist and remove them. Then, install PWAsForFirefox again.

@AxelTerizaki
Copy link

Oooh yeah, thank you, that did the trick! I only had one version installed though and no Regedit keys after uninstalling, so I only had to uninstall then reinstall and the extension worked again :)

@filips123 filips123 unpinned this issue May 7, 2024
@Opisek
Copy link

Opisek commented Oct 1, 2024

Just got this same issue with firefox 131.0 and firefoxpwa 2.12.4

@filips123
Copy link
Owner

You need to update the native program to 2.12.5. The extension will say it's outdated, but you can ignore this until the new version is approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

9 participants