Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display of multiline commit messages #40

Closed
jamescowie opened this issue Dec 16, 2016 · 7 comments
Closed

Display of multiline commit messages #40

jamescowie opened this issue Dec 16, 2016 · 7 comments
Labels

Comments

@jamescowie
Copy link

When a commit message is spread over multiple lines E.g.:

This is first line of message:
* Second
* Third

Then only the first line This is first line of message: gets output in the table.

@luizperes
Copy link
Collaborator

@jamescowie I was think also to include ... instead of showing the whole message, in cases like that

@jamescowie
Copy link
Author

Ah looking into code it looks like it was a choice already made. https://github.com/cloudson/gitql/blob/develop/runtime/commits.go#L90 I might look at options to show based on setting runtime arg.

@jamescowie
Copy link
Author

Ok proposed solution that I have working is to have 2 types e.g. Message and that shows single line and full_message to show multi line.

or is this just better to remove filter for multi lines ?

@luizperes
Copy link
Collaborator

I like the idea of having two types... what do you think @cloudson ?

@filhodanuvem
Copy link
Owner

filhodanuvem commented Dec 17, 2016

Hey guys, the commits table have already the two columns message and full_message.
But I know that the table is showed broken when we do

select author, full_message from commits

Maybe we can work in a new way to print a table.

@jamescowie
Copy link
Author

Thanks for the reply. I found that when printing full message. I'm looking at how the table cells get rendered in an effort to make it fluid. However still learning to at the same time.

@luizperes
Copy link
Collaborator

Any news regarding that @jamescowie ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants