Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when searching for something that isn't in a message #20

Closed
Frozenfire92 opened this issue Dec 14, 2016 · 1 comment
Closed

Error when searching for something that isn't in a message #20

Frozenfire92 opened this issue Dec 14, 2016 · 1 comment
Labels

Comments

@Frozenfire92
Copy link

When doing a command like

gitql "select hash, message from commits where 'hasdfjk' in message order by date asc"

I get

panic: runtime error: slice bounds out of range

goroutine 1 [running]:
panic(0x5a5d20, 0xc820010170)
        /usr/lib/go-1.6/src/runtime/panic.go:481 +0x3e6
github.com/cloudson/gitql/runtime.walkCommits(0xc82000a560, 0xc820053e50)
        /home/joel/Go/src/github.com/cloudson/gitql/runtime/commits.go:58 +0x42e
github.com/cloudson/gitql/runtime.Run(0xc82000a560)
        /home/joel/Go/src/github.com/cloudson/gitql/runtime/runtime.go:79 +0x15f
main.main()
        /home/joel/Go/src/github.com/cloudson/gitql/gitql.go:29 +0x372

This should fail more gracefully

@filhodanuvem
Copy link
Owner

filhodanuvem commented Dec 29, 2016

Sorry for the late @Frozenfire92 . I found the problem that you mentioned here and fixed it.
Now, gitql will return a empty table as result. We can discuss about a new way to show results in cases like that in another issue.
Thank you for report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants