Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate DHT put issue (go-libp2p-kad-dht) #437

Closed
laser opened this issue May 15, 2018 · 4 comments
Closed

Investigate DHT put issue (go-libp2p-kad-dht) #437

laser opened this issue May 15, 2018 · 4 comments

Comments

@laser
Copy link
Contributor

laser commented May 15, 2018

Split out from @whyrusleeping 's original catch-all issue.

Description

Address issues described here.

Acceptance criteria

TBD

Risks + pitfalls

TBD

Where to begin

TBD

@laser laser added the dep:ipfs label May 15, 2018
@laser laser changed the title PutValue might be broken (go-libp2p-kad-dht) Investigate DHT put issue (go-libp2p-kad-dht) May 15, 2018
@raulk
Copy link
Member

raulk commented Feb 13, 2019

@whyrusleeping @laser could you clarify how you use this feature? From what we understood, FC only uses peer routing at the moment.

cc/ @anacrolix

@whyrusleeping
Copy link
Member

@raulk its not so much the DHT put, but the issues that were plaguing it. I think that the dial issue you fixed recently might have been the root cause actually.

@raulk
Copy link
Member

raulk commented Feb 26, 2019

@whyrusleeping that makes sense. Puts make lots of dials to lookup the K=20 closest peers to the key, then sends PutValue RPCs to them. If the dialer was stalling, it would somewhat explain the behaviour observed here.

Do we want to close this issue and reopen if we notice it again?

@whyrusleeping
Copy link
Member

Yeah, let's close for now. Hopefully its fixed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants