Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add docker push #131

Merged
merged 3 commits into from
Apr 4, 2023
Merged

Feat/add docker push #131

merged 3 commits into from
Apr 4, 2023

Conversation

hunjixin
Copy link
Contributor

@hunjixin hunjixin commented Apr 4, 2023

关联的Issues (Related Issues)

close filecoin-project/venus#5890

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@hunjixin hunjixin force-pushed the feat/add_docker_push branch from 02ba0de to dce8673 Compare April 4, 2023 05:35
@codecov-commenter
Copy link

Codecov Report

Merging #131 (02ba0de) into master (c591b11) will increase coverage by 0.71%.
The diff coverage is 60.00%.

❗ Current head 02ba0de differs from pull request most recent head dce8673. Consider uploading reports for the commit dce8673 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #131      +/-   ##
==========================================
+ Coverage   32.74%   33.45%   +0.71%     
==========================================
  Files          42       42              
  Lines        2669     2672       +3     
==========================================
+ Hits          874      894      +20     
+ Misses       1642     1622      -20     
- Partials      153      156       +3     
Flag Coverage Δ
unittests 33.45% <60.00%> (+0.71%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cli/wallet.go 0.00% <ø> (ø)
crypto/delegated.go 53.24% <0.00%> (+23.37%) ⬆️
storage/wallet/wallet.go 22.59% <0.00%> (-0.11%) ⬇️
cmd/rpc.go 55.26% <100.00%> (+0.59%) ⬆️
storage/sqlite/key_types.go 85.00% <100.00%> (+0.78%) ⬆️

Copy link
Collaborator

@simlecode simlecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@simlecode simlecode merged commit 6fe40e0 into master Apr 4, 2023
@simlecode simlecode deleted the feat/add_docker_push branch April 4, 2023 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[venus-*] support private registry in docker push / 增加推送到镜像仓库的功能
3 participants