Feat: unit test/核心模块单元测试 #122

diwufeiwen · 2022-08-01T08:55:14Z

关联的Issues (Related Issues)

fixes filecoin-project/venus#4916

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前，需要确保 / Before you mark the PR ready for review, please make sure that:

符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
具有清晰明确的commit message / All commits have a clear commit message.
包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
通过必要的检查项 / All checks are green

codecov-commenter · 2022-08-04T08:51:14Z

Codecov Report

Merging #122 (ec5af6d) into master (3d6b12a) will increase coverage by 19.83%.
The diff coverage is 41.81%.

Additional details and impacted files

@@             Coverage Diff             @@
##           master     #122       +/-   ##
===========================================
+ Coverage    8.58%   28.41%   +19.83%     
===========================================
  Files          36       57       +21     
  Lines        1923     3853     +1930     
===========================================
+ Hits          165     1095      +930     
- Misses       1715     2611      +896     
- Partials       43      147      +104

Flag	Coverage Δ
unittests	`28.41% <41.81%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
api/api_common.go	`0.00% <ø> (ø)`
cmd/init.go	`0.00% <0.00%> (ø)`
cmd/run.go	`0.00% <0.00%> (ø)`
miner/mock/mock_post_provider.go	`0.00% <0.00%> (ø)`
node/impl/common/common.go	`0.00% <ø> (ø)`
node/modules/miner.go	`0.00% <ø> (ø)`
node/modules/slashfilter/api.go	`0.00% <0.00%> (ø)`
node/modules/slashfilter/slashfilter.go	`54.48% <ø> (ø)`
miner/multiminer.go	`60.93% <46.34%> (+60.93%)`	⬆️
node/modules/miner-manager/mock/miner_manager.go	`50.00% <50.00%> (ø)`
... and 51 more

zl03jsj

以下问题需要解决:

测试存在大量的`data race`错误..

go test ./miner -race -coverprofile=coverrage.out -v                                                                                                                   
=== RUN   TestSuccessMinerBlocks
..........省略..........
2022-09-16T17:41:21.348+0800	INFO	miner	miner/multiminer.go:377	mined new block	{"cid": "bafy2bzaceb5opma7oipluzrxwbapjfpzrijbmqzwdxwb5y4lxigluxzdvb4jk", "height": "1", "miner": "t03", "parents": ["t01"], "weight": "102", "took": 0.007377834}
winner 1
2022-09-16T17:41:21.349+0800	INFO	miner	miner/multiminer.go:377	mined new block	{"cid": "bafy2bzaceci6oryl25li52gs7nobdq2bqxc5o66vctcvjyp42xgwht2ldjrjs", "height": "1", "miner": "t04", "parents": ["t01"], "weight": "102", "took": 0.007914222}
==================
WARNING: DATA RACE
Write at 0x00c0002ca000 by goroutine 53:
  github.com/filecoin-project/venus-miner/miner.(*Miner).mine.func2()
      /Users/zl/workspace/go/src/filcoin-projects/venus/venus-miner/miner/multiminer.go:444 +0x996
  github.com/filecoin-project/venus-miner/miner.(*Miner).mine.func5()
      /Users/zl/workspace/go/src/filcoin-projects/venus/venus-miner/miner/multiminer.go:453 +0x47

Previous read at 0x00c0002ca000 by goroutine 55:
  github.com/filecoin-project/venus-miner/miner.(*Miner).mine.func2()
      /Users/zl/workspace/go/src/filcoin-projects/venus/venus-miner/miner/multiminer.go:438 +0x70a
  github.com/filecoin-project/venus-miner/miner.(*Miner).mine.func5()
      /Users/zl/workspace/go/src/filcoin-projects/venus/venus-miner/miner/multiminer.go:453 +0x47

Goroutine 53 (running) created at:
  github.com/filecoin-project/venus-miner/miner.(*Miner).mine()
      /Users/zl/workspace/go/src/filcoin-projects/venus/venus-miner/miner/multiminer.go:421 +0x3dc4
  github.com/filecoin-project/venus-miner/miner.(*Miner).Start.func2()
      /Users/zl/workspace/go/src/filcoin-projects/venus/venus-miner/miner/multiminer.go:192 +0x58

Goroutine 55 (running) created at:
  github.com/filecoin-project/venus-miner/miner.(*Miner).mine()
      /Users/zl/workspace/go/src/filcoin-projects/venus/venus-miner/miner/multiminer.go:421 +0x3dc4
  github.com/filecoin-project/venus-miner/miner.(*Miner).Start.func2()
      /Users/zl/workspace/go/src/filcoin-projects/venus/venus-miner/miner/multiminer.go:192 +0x58
==================
==================
WARNING: DATA RACE
Read at 0x00c002121bd0 by goroutine 55:
  context.(*valueCtx).Value()
      /usr/local/opt/go/src/context/context.go:563 +0x45
  go.opencensus.io/tag.FromContext()
      /Users/zl/workspace/go/pkg/mod/[email protected]/tag/context.go:25 +0xca
  go.opencensus.io/tag.New()
      /Users/zl/workspace/go/pkg/mod/[email protected]/tag/map.go:189 +0xf3
  github.com/filecoin-project/venus-miner/miner.(*Miner).mine.func2()
      /Users/zl/workspace/go/src/filcoin-projects/venus/venus-miner/miner/multiminer.go:444 +0x979
  github.com/filecoin-project/venus-miner/miner.(*Miner).mine.func5()
      /Users/zl/workspace/go/src/filcoin-projects/venus/venus-miner/miner/multiminer.go:453 +0x47

Previous write at 0x00c002121bd0 by goroutine 53:
  context.WithValue()
      /usr/local/opt/go/src/context/context.go:533 +0x106
  go.opencensus.io/tag.NewContext()
      /Users/zl/workspace/go/pkg/mod/[email protected]/tag/context.go:38 +0x194
  go.opencensus.io/tag.New()
      /Users/zl/workspace/go/pkg/mod/[email protected]/tag/map.go:208 +0x16a
  github.com/filecoin-project/venus-miner/miner.(*Miner).mine.func2()
      /Users/zl/workspace/go/src/filcoin-projects/venus/venus-miner/miner/multiminer.go:444 +0x979
  github.com/filecoin-project/venus-miner/miner.(*Miner).mine.func5()
      /Users/zl/workspace/go/src/filcoin-projects/venus/venus-miner/miner/multiminer.go:453 +0x47

Goroutine 55 (running) created at:
  github.com/filecoin-project/venus-miner/miner.(*Miner).mine()
      /Users/zl/workspace/go/src/filcoin-projects/venus/venus-miner/miner/multiminer.go:421 +0x3dc4
  github.com/filecoin-project/venus-miner/miner.(*Miner).Start.func2()
      /Users/zl/workspace/go/src/filcoin-projects/venus/venus-miner/miner/multiminer.go:192 +0x58

Goroutine 53 (running) created at:
  github.com/filecoin-project/venus-miner/miner.(*Miner).mine()
      /Users/zl/workspace/go/src/filcoin-projects/venus/venus-miner/miner/multiminer.go:421 +0x3dc4
  github.com/filecoin-project/venus-miner/miner.(*Miner).Start.func2()
      /Users/zl/workspace/go/src/filcoin-projects/venus/venus-miner/miner/multiminer.go:192 +0x58
==================
==================
WARNING: DATA RACE
Read at 0x00c002121be0 by goroutine 55:
  context.(*valueCtx).Value()
      /usr/local/opt/go/src/context/context.go:564 +0xc6
  go.opencensus.io/tag.FromContext()
      /Users/zl/workspace/go/pkg/mod/[email protected]/tag/context.go:25 +0xca
  go.opencensus.io/tag.New()
      /Users/zl/workspace/go/pkg/mod/[email protected]/tag/map.go:189 +0xf3
  github.com/filecoin-project/venus-miner/miner.(*Miner).mine.func2()
      /Users/zl/workspace/go/src/filcoin-projects/venus/venus-miner/miner/multiminer.go:444 +0x979
  github.com/filecoin-project/venus-miner/miner.(*Miner).mine.func5()
      /Users/zl/workspace/go/src/filcoin-projects/venus/venus-miner/miner/multiminer.go:453 +0x47

Previous write at 0x00c002121be0 by goroutine 53:
  context.WithValue()
      /usr/local/opt/go/src/context/context.go:533 +0x144
  go.opencensus.io/tag.NewContext()
      /Users/zl/workspace/go/pkg/mod/[email protected]/tag/context.go:38 +0x194
  go.opencensus.io/tag.New()
      /Users/zl/workspace/go/pkg/mod/[email protected]/tag/map.go:208 +0x16a
  github.com/filecoin-project/venus-miner/miner.(*Miner).mine.func2()
      /Users/zl/workspace/go/src/filcoin-projects/venus/venus-miner/miner/multiminer.go:444 +0x979
  github.com/filecoin-project/venus-miner/miner.(*Miner).mine.func5()
      /Users/zl/workspace/go/src/filcoin-projects/venus/venus-miner/miner/multiminer.go:453 +0x47

Goroutine 55 (running) created at:
  github.com/filecoin-project/venus-miner/miner.(*Miner).mine()
      /Users/zl/workspace/go/src/filcoin-projects/venus/venus-miner/miner/multiminer.go:421 +0x3dc4
  github.com/filecoin-project/venus-miner/miner.(*Miner).Start.func2()
      /Users/zl/workspace/go/src/filcoin-projects/venus/venus-miner/miner/multiminer.go:192 +0x58

Goroutine 53 (running) created at:
  github.com/filecoin-project/venus-miner/miner.(*Miner).mine()
      /Users/zl/workspace/go/src/filcoin-projects/venus/venus-miner/miner/multiminer.go:421 +0x3dc4
  github.com/filecoin-project/venus-miner/miner.(*Miner).Start.func2()
      /Users/zl/workspace/go/src/filcoin-projects/venus/venus-miner/miner/multiminer.go:192 +0x58
==================
==================
WARNING: DATA RACE
Read at 0x00c0000101a0 by goroutine 55:
  go.opencensus.io/tag.New()
      /Users/zl/workspace/go/pkg/mod/[email protected]/tag/map.go:191 +0x104
  github.com/filecoin-project/venus-miner/miner.(*Miner).mine.func2()
      /Users/zl/workspace/go/src/filcoin-projects/venus/venus-miner/miner/multiminer.go:444 +0x979
  github.com/filecoin-project/venus-miner/miner.(*Miner).mine.func5()
      /Users/zl/workspace/go/src/filcoin-projects/venus/venus-miner/miner/multiminer.go:453 +0x47

Previous write at 0x00c0000101a0 by goroutine 53:
  go.opencensus.io/tag.newMap()
      /Users/zl/workspace/go/pkg/mod/[email protected]/tag/map.go:92 +0x79
  go.opencensus.io/tag.New()
      /Users/zl/workspace/go/pkg/mod/[email protected]/tag/map.go:188 +0x56
  github.com/filecoin-project/venus-miner/miner.(*Miner).mine.func2()
      /Users/zl/workspace/go/src/filcoin-projects/venus/venus-miner/miner/multiminer.go:444 +0x979
  github.com/filecoin-project/venus-miner/miner.(*Miner).mine.func5()
      /Users/zl/workspace/go/src/filcoin-projects/venus/venus-miner/miner/multiminer.go:453 +0x47

Goroutine 55 (running) created at:
  github.com/filecoin-project/venus-miner/miner.(*Miner).mine()
      /Users/zl/workspace/go/src/filcoin-projects/venus/venus-miner/miner/multiminer.go:421 +0x3dc4
  github.com/filecoin-project/venus-miner/miner.(*Miner).Start.func2()
      /Users/zl/workspace/go/src/filcoin-projects/venus/venus-miner/miner/multiminer.go:192 +0x58

Goroutine 53 (running) created at:
  github.com/filecoin-project/venus-miner/miner.(*Miner).mine()
      /Users/zl/workspace/go/src/filcoin-projects/venus/venus-miner/miner/multiminer.go:421 +0x3dc4
  github.com/filecoin-project/venus-miner/miner.(*Miner).Start.func2()
      /Users/zl/workspace/go/src/filcoin-projects/venus/venus-miner/miner/multiminer.go:192 +0x58
==================
==================
WARNING: DATA RACE
Read at 0x00c002121b90 by goroutine 55:
  runtime.mapiterinit()
      /usr/local/opt/go/src/runtime/map.go:815 +0x0
  go.opencensus.io/tag.New()
      /Users/zl/workspace/go/pkg/mod/[email protected]/tag/map.go:191 +0x146
  github.com/filecoin-project/venus-miner/miner.(*Miner).mine.func2()
      /Users/zl/workspace/go/src/filcoin-projects/venus/venus-miner/miner/multiminer.go:444 +0x979
  github.com/filecoin-project/venus-miner/miner.(*Miner).mine.func5()
      /Users/zl/workspace/go/src/filcoin-projects/venus/venus-miner/miner/multiminer.go:453 +0x47

Previous write at 0x00c002121b90 by goroutine 53:
  runtime.mapassign_faststr()
      /usr/local/opt/go/src/runtime/map_faststr.go:203 +0x0
  go.opencensus.io/tag.(*Map).upsert()
      /Users/zl/workspace/go/pkg/mod/[email protected]/tag/map.go:84 +0x1bc
  go.opencensus.io/tag.Upsert.func1()
      /Users/zl/workspace/go/pkg/mod/[email protected]/tag/map.go:152 +0x151
  go.opencensus.io/tag.(*mutator).Mutate()
      /Users/zl/workspace/go/pkg/mod/[email protected]/tag/map.go:228 +0x45
  go.opencensus.io/tag.New()
      /Users/zl/workspace/go/pkg/mod/[email protected]/tag/map.go:203 +0x213
  github.com/filecoin-project/venus-miner/miner.(*Miner).mine.func2()
      /Users/zl/workspace/go/src/filcoin-projects/venus/venus-miner/miner/multiminer.go:444 +0x979
  github.com/filecoin-project/venus-miner/miner.(*Miner).mine.func5()
      /Users/zl/workspace/go/src/filcoin-projects/venus/venus-miner/miner/multiminer.go:453 +0x47

TestCountWinner 偶发性失败

go test ./miner -coverprofile=coverrage.out -v     
...省略...
=== RUN   TestCountWinner
...省略...
2022-09-16T23:32:48.011+0800	INFO	miner	miner/multiminer.go:821	mined new block ( -> Proof)	{"took": 0.000967035, "miner": "t04"}
2022-09-16T23:32:48.011+0800	INFO	miner	miner/multiminer.go:306	mining compute	{"number of wins": 4, "total miner": 4}
2022-09-16T23:32:48.011+0800	INFO	miner	miner/multiminer.go:347	select message	{"tickets": 4}
winner 1
2022-09-16T23:32:48.011+0800	INFO	miner	miner/multiminer.go:377	mined new block	{"cid": "bafy2bzaceay2usrr56rxftd3xzizbf2ni45l766xnd6tzsckgkartjjn57zxy", "height": "12", "miner": "t05", "parents": ["t013"], "weight": "113", "took": 0.001264888}
winner 1
2022-09-16T23:32:48.011+0800	INFO	miner	miner/multiminer.go:377	mined new block	{"cid": "bafy2bzacect462bggesoll4qoikhhrzspemeyepyy4dzehaxg4pwqjgj2pnaw", "height": "12", "miner": "t03", "parents": ["t013"], "weight": "113", "took": 0.00135003}
winner 1
2022-09-16T23:32:48.011+0800	INFO	miner	miner/multiminer.go:377	mined new block	{"cid": "bafy2bzacebr6g4xfp2jrzjmrmxuf5gsmfusopvd2qca5au3zbb2r2zwvwf5ci", "height": "12", "miner": "t02", "parents": ["t013"], "weight": "113", "took": 0.001344888}
winner 1
2022-09-16T23:32:48.011+0800	INFO	miner	miner/multiminer.go:377	mined new block	{"cid": "bafy2bzacedbdcmwgjnulbdk5zsmvqfrjypyo3zhznscxq6lldp3pgzyqowii4", "height": "12", "miner": "t04", "parents": ["t013"], "weight": "113", "took": 0.001440865}
2022-09-16T23:32:48.011+0800	WARN	miner	miner/multiminer.go:415	mined block in the past	{"block-time": "1970-01-01T08:02:00.000+0800", "time": "2022-09-16T23:32:48.011+0800", "difference": 1663342248.011594}
2022-09-16T23:32:48.011+0800	INFO	miner	miner/multiminer.go:282	sync status	{"HeightDiff": 0, "err:": null}
2022-09-16T23:32:48.011+0800	WARN	miner	miner/multiminer.go:299	BestMiningCandidate from the previous round: [bafy2bzaceaj7fe56x3hlxmgkrjzctcuiuczexbw74lu3idcrizjoxbtn6ppvs] (nulls:0)
2022-09-16T23:32:48.012+0800	INFO	miner	miner/miningmgr.go:135	count winners, addrs: [t02 t03 t04 t05], start: 0, end: 4

    miner_test.go:90:
        	Error Trace:	miner_test.go:90
        	            				once.go:68
        	            				once.go:59
        	            				miner_test.go:81
        	Error:      	Not equal:
        	            	expected: 0
        	            	actual  : 2
        	Test:       	TestCountWinner

    miner_test.go:90:
        	Error Trace:	miner_test.go:90
        	            				once.go:68
        	            				once.go:59
        	            				miner_test.go:81
        	Error:      	Not equal:
        	            	expected: 0
        	            	actual  : 3
        	Test:       	TestCountWinner

    miner_test.go:90:
        	Error Trace:	miner_test.go:90
        	            				once.go:68
        	            				once.go:59
        	            				miner_test.go:81
        	Error:      	Not equal:
        	            	expected: 0
        	            	actual  : 2
        	Test:       	TestCountWinner

    miner_test.go:90:
        	Error Trace:	miner_test.go:90
        	            				once.go:68
        	            				once.go:59
        	            				miner_test.go:81
        	Error:      	Not equal:
        	            	expected: 0
        	            	actual  : 5
        	Test:       	TestCountWinner
--- FAIL: TestCountWinner (113.02s)

TestManualStartAndStop 出现偶发性崩溃

go test ./miner -coverprofile=coverrage.out -v
...
=== RUN   TestManualStartAndStop
........
2022-09-16T23:39:51.063+0800	INFO	miner	miner/multiminer.go:673	attempting to mine a block	{"tipset": ["bafy2bzaceba5gsryqb5hrtouf2kucgwb7eoyo5xgtytec6aemt6sdwmnbjjzm"], "miner": "t05"}
2022-09-16T23:39:51.063+0800	INFO	miner	miner/multiminer.go:673	attempting to mine a block	{"tipset": ["bafy2bzaceba5gsryqb5hrtouf2kucgwb7eoyo5xgtytec6aemt6sdwmnbjjzm"], "miner": "t03"}
2022-09-16T23:39:51.063+0800	INFO	miner	miner/multiminer.go:673	attempting to mine a block	{"tipset": ["bafy2bzaceba5gsryqb5hrtouf2kucgwb7eoyo5xgtytec6aemt6sdwmnbjjzm"], "miner": "t04"}
2022-09-16T23:39:51.063+0800	INFO	miner	miner/multiminer.go:673	attempting to mine a block	{"tipset": ["bafy2bzaceba5gsryqb5hrtouf2kucgwb7eoyo5xgtytec6aemt6sdwmnbjjzm"], "miner": "t02"}
2022-09-16T23:39:51.630+0800	ERROR	miner	miner/multiminer.go:545	mining timeout for t05
2022-09-16T23:39:51.630+0800	ERROR	miner	miner/multiminer.go:545	mining timeout for t03
2022-09-16T23:39:51.630+0800	ERROR	miner	miner/multiminer.go:545	mining timeout for t04
2022-09-16T23:39:51.630+0800	ERROR	miner	miner/multiminer.go:545	mining timeout for t02
2022-09-16T23:39:51.631+0800	INFO	miner	miner/multiminer.go:306	mining compute	{"number of wins": 0, "total miner": 4}
2022-09-16T23:39:51.631+0800	WARN	miner	miner/multiminer.go:322	chain has been forked	{"new base": ["bafy2bzacebgomalrbkew24lqlfrex2fdiguizgj236ox5p3llhvxbdrjgbyik"], "base": ["bafy2bzacedyv5tq45frxcofmwcyoy4twp3bemom6xosuxk63453b3zt47wbo6"]}
2022-09-16T23:39:51.631+0800	INFO	miner	miner/multiminer.go:457	no block and increase nullround
2022-09-16T23:39:51.631+0800	INFO	miner	miner/multiminer.go:282	sync status	{"HeightDiff": 0, "err:": null}
2022-09-16T23:39:51.631+0800	INFO	miner	miner/multiminer.go:673	attempting to mine a block	{"tipset": ["bafy2bzacebgomalrbkew24lqlfrex2fdiguizgj236ox5p3llhvxbdrjgbyik"], "miner": "t04"}
2022-09-16T23:39:51.631+0800	INFO	miner	miner/multiminer.go:673	attempting to mine a block	{"tipset": ["bafy2bzacebgomalrbkew24lqlfrex2fdiguizgj236ox5p3llhvxbdrjgbyik"], "miner": "t02"}
2022-09-16T23:39:51.631+0800	INFO	miner	miner/multiminer.go:673	attempting to mine a block	{"tipset": ["bafy2bzacebgomalrbkew24lqlfrex2fdiguizgj236ox5p3llhvxbdrjgbyik"], "miner": "t03"}
2022-09-16T23:39:51.631+0800	INFO	miner	miner/multiminer.go:673	attempting to mine a block	{"tipset": ["bafy2bzacebgomalrbkew24lqlfrex2fdiguizgj236ox5p3llhvxbdrjgbyik"], "miner": "t05"}
2022-09-16T23:39:52.608+0800	ERROR	miner	miner/multiminer.go:545	mining timeout for t02
2022-09-16T23:39:52.608+0800	ERROR	miner	miner/multiminer.go:545	mining timeout for t03
2022-09-16T23:39:52.608+0800	INFO	miner	miner/multiminer.go:306	mining compute	{"number of wins": 0, "total miner": 2}
2022-09-16T23:39:52.609+0800	INFO	miner	miner/multiminer.go:457	no block and increase nullround
2022-09-16T23:39:52.609+0800	INFO	miner	miner/multiminer.go:282	sync status	{"HeightDiff": 0, "err:": null}
2022-09-16T23:39:52.609+0800	WARN	miner	miner/multiminer.go:299	BestMiningCandidate from the previous round: [bafy2bzacecqiadefims4wywfiinityuni25srlfn2asglcpsnrldjzbkeahhe] (nulls:0)
2022-09-16T23:39:53.864+0800	ERROR	miner	miner/multiminer.go:545	mining timeout for t05
2022-09-16T23:39:53.864+0800	ERROR	miner	miner/multiminer.go:545	mining timeout for t02
2022-09-16T23:39:53.864+0800	ERROR	miner	miner/multiminer.go:545	mining timeout for t04
2022-09-16T23:39:53.864+0800	ERROR	miner	miner/multiminer.go:545	mining timeout for t03
2022-09-16T23:39:53.865+0800	INFO	miner	miner/multiminer.go:306	mining compute	{"number of wins": 0, "total miner": 4}
2022-09-16T23:39:53.865+0800	INFO	miner	miner/multiminer.go:457	no block and increase nullround
2022-09-16T23:39:53.865+0800	INFO	miner	miner/multiminer.go:282	sync status	{"HeightDiff": 0, "err:": null}
2022-09-16T23:39:53.865+0800	WARN	miner	miner/multiminer.go:299	BestMiningCandidate from the previous round: [bafy2bzaceba5gsryqb5hrtouf2kucgwb7eoyo5xgtytec6aemt6sdwmnbjjzm] (nulls:0)
2022-09-16T23:39:53.996+0800	INFO	miner	miner/miner_test.go:861	insert new block 17
2022-09-16T23:39:53.998+0800	INFO	miner	miner/miner_test.go:861	insert new block 10
2022-09-16T23:39:54.432+0800	ERROR	miner	miner/multiminer.go:545	mining timeout for t03
2022-09-16T23:39:54.432+0800	ERROR	miner	miner/multiminer.go:545	mining timeout for t05
2022-09-16T23:39:54.432+0800	ERROR	miner	miner/multiminer.go:545	mining timeout for t02
2022-09-16T23:39:54.432+0800	ERROR	miner	miner/multiminer.go:545	mining timeout for t04
2022-09-16T23:39:54.432+0800	INFO	miner	miner/multiminer.go:306	mining compute	{"number of wins": 0, "total miner": 4}
2022-09-16T23:39:54.432+0800	INFO	miner	miner/multiminer.go:457	no block and increase nullround
2022-09-16T23:39:54.432+0800	INFO	miner	miner/multiminer.go:282	sync status	{"HeightDiff": 0, "err:": null}
2022-09-16T23:39:54.433+0800	WARN	miner	miner/multiminer.go:299	BestMiningCandidate from the previous round: [bafy2bzacebgomalrbkew24lqlfrex2fdiguizgj236ox5p3llhvxbdrjgbyik] (nulls:0)
coverage: 61.6% of statements
panic: test timed out after 10m0s

goroutine 3336 [running]:
testing.(*M).startAlarm.func1()
	/usr/local/opt/go/src/testing/testing.go:2029 +0x8e
created by time.goFunc
	/usr/local/opt/go/src/time/sleep.go:176 +0x32

goroutine 1 [chan receive, 2 minutes]:
testing.(*T).Run(0xc000293a00, {0x5499dde?, 0x73a542bc1a81?}, 0x5621868)
	/usr/local/opt/go/src/testing/testing.go:1487 +0x37a
testing.runTests.func1(0xc0000fa9f0?)
	/usr/local/opt/go/src/testing/testing.go:1839 +0x6e
testing.tRunner(0xc000293a00, 0xc000031ca0)
	/usr/local/opt/go/src/testing/testing.go:1439 +0x102
testing.runTests(0xc0004c57c0?, {0x6289980, 0x9, 0x9}, {0x66a8108?, 0x40?, 0x62a1360?})
	/usr/local/opt/go/src/testing/testing.go:1837 +0x457
testing.(*M).Run(0xc0004c57c0)
	/usr/local/opt/go/src/testing/testing.go:1719 +0x5d9
main.main()
	_testmain.go:121 +0x255

goroutine 21 [select, 10 minutes]:
github.com/ipfs/go-log/writer.(*MirrorWriter).logRoutine(0xc0001f7e60)
	/Users/zl/workspace/go/pkg/mod/github.com/ipfs/[email protected]/writer/writer.go:71 +0x11f
created by github.com/ipfs/go-log/writer.NewMirrorWriter
	/Users/zl/workspace/go/pkg/mod/github.com/ipfs/[email protected]/writer/writer.go:36 +0xca

goroutine 22 [select, 2 minutes]:
go.opencensus.io/stats/view.(*worker).start(0xc000202280)
	/Users/zl/workspace/go/pkg/mod/[email protected]/stats/view/worker.go:276 +0xad
created by go.opencensus.io/stats/view.init.0
	/Users/zl/workspace/go/pkg/mod/[email protected]/stats/view/worker.go:34 +0x8d

goroutine 27 [sleep, 2 minutes]:
time.Sleep(0x1dcd6500)
	/usr/local/opt/go/src/runtime/time.go:194 +0x12e
github.com/awnumar/memguard/core.NewCoffer.func1(0x0?)
	/Users/zl/workspace/go/pkg/mod/github.com/awnumar/[email protected]/core/coffer.go:43 +0x25
created by github.com/awnumar/memguard/core.NewCoffer
	/Users/zl/workspace/go/pkg/mod/github.com/awnumar/[email protected]/core/coffer.go:40 +0x105

goroutine 502 [select, 2 minutes]:
io.(*pipe).read(0xc0020c4ba0, {0xc00274c587, 0xa79, 0xb7?})
	/usr/local/opt/go/src/io/pipe.go:57 +0xb1
io.(*PipeReader).Read(...)
	/usr/local/opt/go/src/io/pipe.go:136
github.com/ipfs/go-log/v2.(*PipeReader).Read(0xc00274c4cf?, {0xc00274c587?, 0xb31?, 0xc0025d6f00?})
	/Users/zl/workspace/go/pkg/mod/github.com/ipfs/go-log/[email protected]/pipe.go:20 +0x25
bufio.(*Scanner).Scan(0xc00230d600)
	/usr/local/opt/go/src/bufio/scan.go:215 +0x865
github.com/filecoin-project/venus-miner/miner.newLogMatcher.func1()
	/Users/zl/workspace/go/src/filcoin-projects/venus/venus-miner/miner/miner_test.go:946 +0x36
created by github.com/filecoin-project/venus-miner/miner.newLogMatcher
	/Users/zl/workspace/go/src/filcoin-projects/venus/venus-miner/miner/miner_test.go:945 +0x145

goroutine 3168 [select, 2 minutes]:
github.com/filecoin-project/venus-miner/miner.TestManualStartAndStop(0xc002578b60)
	/Users/zl/workspace/go/src/filcoin-projects/venus/venus-miner/miner/miner_test.go:305 +0x246
testing.tRunner(0xc002578b60, 0x5621868)
	/usr/local/opt/go/src/testing/testing.go:1439 +0x102
created by testing.(*T).Run
	/usr/local/opt/go/src/testing/testing.go:1486 +0x35
...省略...
FAIL	github.com/filecoin-project/venus-miner/miner	600.393s
FAIL

miner/miner_test.go

hunjixin · 2022-09-19T05:34:01Z

超时是正常的，要设置下duration时间

zl03jsj

diwufeiwen assigned zl03jsj Aug 1, 2022

zl03jsj marked this pull request as draft August 8, 2022 01:29

zl03jsj force-pushed the feat/unit_test branch from 9af337c to 99ab21e Compare August 8, 2022 01:41

zl03jsj mentioned this pull request Aug 8, 2022

Sprint 46 filecoin-project/venus#5162

Closed

25 tasks

zl03jsj force-pushed the feat/unit_test branch 2 times, most recently from 7aa83ff to 6bb570e Compare August 8, 2022 04:29

zl03jsj marked this pull request as ready for review August 8, 2022 09:20

zl03jsj requested review from hunjixin and simlecode August 8, 2022 09:20

zl03jsj assigned diwufeiwen Aug 8, 2022

zl03jsj force-pushed the feat/unit_test branch 3 times, most recently from 3ce3fd4 to 60ba8a0 Compare August 10, 2022 11:40

Fatman13 mentioned this pull request Aug 19, 2022

Sprint 47 filecoin-project/venus#5205

Closed

33 tasks

Fatman13 mentioned this pull request Sep 2, 2022

Sprint 48 filecoin-project/venus#5257

Closed

31 tasks

hunjixin force-pushed the feat/unit_test branch 3 times, most recently from 96d7b6c to 0058fa7 Compare September 15, 2022 09:28

Fatman13 mentioned this pull request Sep 16, 2022

Sprint 49 filecoin-project/venus#5296

Closed

54 tasks

zl03jsj reviewed Sep 16, 2022

View reviewed changes

hunjixin force-pushed the feat/unit_test branch from 207c0e8 to b603020 Compare September 21, 2022 06:48

ta0li and others added 4 commits September 26, 2022 16:34

feat: mysql slash filter test case, mock miner manager api

e33dd13

tests: 增加miner核心逻辑单元测试/add unit test for mining core.

b2561ff

refactor: refactor the unit test of mining core by @hunjixin

b123a91

feat: add unit-test and lint check git actions

ec5af6d

zl03jsj force-pushed the feat/unit_test branch from b603020 to ec5af6d Compare September 27, 2022 01:16

zl03jsj approved these changes Sep 27, 2022

View reviewed changes

zl03jsj merged commit 83ad485 into master Sep 27, 2022

zl03jsj deleted the feat/unit_test branch September 27, 2022 02:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat: unit test/核心模块单元测试 #122

Feat: unit test/核心模块单元测试 #122

diwufeiwen commented Aug 1, 2022 •

edited by zl03jsj

Loading

codecov-commenter commented Aug 4, 2022 •

edited

Loading

zl03jsj left a comment •

edited

Loading

hunjixin commented Sep 19, 2022

zl03jsj left a comment

Feat: unit test/核心模块单元测试 #122

Feat: unit test/核心模块单元测试 #122

Conversation

diwufeiwen commented Aug 1, 2022 • edited by zl03jsj Loading

关联的Issues (Related Issues)

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

codecov-commenter commented Aug 4, 2022 • edited Loading

Codecov Report

zl03jsj left a comment • edited Loading

Choose a reason for hiding this comment

以下问题需要解决:

测试存在大量的data race错误..

TestCountWinner 偶发性失败

TestManualStartAndStop 出现偶发性崩溃

hunjixin commented Sep 19, 2022

zl03jsj left a comment

Choose a reason for hiding this comment

diwufeiwen commented Aug 1, 2022 •

edited by zl03jsj

Loading

codecov-commenter commented Aug 4, 2022 •

edited

Loading

zl03jsj left a comment •

edited

Loading

测试存在大量的`data race`错误..