-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename BlockSync to ChainExchange #1204
base: master
Are you sure you want to change the base?
Conversation
Deploy is failing probably because I should have updated some index after changing file names, I'll leave that to you @yiannisbot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks generally correct, just giving 2c because asked to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update! A couple of suggestions inline. We'll also need to get the site to compile and change all references to BlockSync in the rest of the spec. But I can take care of that one of the following days.
Co-authored-by: Yiannis Psaras <[email protected]>
If not all Tipsets requested could be fetched, but the `Head` of the chain segment requested was successfully fetched (and potentially more contiguous Tipsets), then this is not considered an error and a `Partial` response code is returned. The node can continue extending the chain from the partial returned segment onwards. | ||
|
||
```go | ||
type Request struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can embed this struct directly from the code https://github.com/filecoin-project/lotus/blob/master/chain/exchange/protocol.go#L48-L60 using https://github.com/filecoin-project/specs#embed
Example:
{{<embed src="https://github.com/filecoin-project/lotus/blob/master/chain/exchange/protocol.go" lang="go" symbol="Request" title="Exchange Protocol Request">}}
This way its easier to keep in sync.
Can you rebase please ? |
Updates names from filecoin-project/lotus#3624 and some protocol packet structure from filecoin-project/lotus#2715.
Closes #1171.