Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename BlockSync to ChainExchange #1204

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

schomatis
Copy link
Contributor

Updates names from filecoin-project/lotus#3624 and some protocol packet structure from filecoin-project/lotus#2715.

Closes #1171.

@schomatis schomatis requested a review from yiannisbot October 12, 2020 15:49
@schomatis
Copy link
Contributor Author

Deploy is failing probably because I should have updated some index after changing file names, I'll leave that to you @yiannisbot.

austinabell
austinabell previously approved these changes Oct 12, 2020
Copy link

@austinabell austinabell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks generally correct, just giving 2c because asked to

content/algorithms/chain_exchange.md Show resolved Hide resolved
Copy link
Collaborator

@yiannisbot yiannisbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! A couple of suggestions inline. We'll also need to get the site to compile and change all references to BlockSync in the rest of the spec. But I can take care of that one of the following days.

content/algorithms/chain_exchange.md Show resolved Hide resolved
content/algorithms/chain_exchange.md Outdated Show resolved Hide resolved
If not all Tipsets requested could be fetched, but the `Head` of the chain segment requested was successfully fetched (and potentially more contiguous Tipsets), then this is not considered an error and a `Partial` response code is returned. The node can continue extending the chain from the partial returned segment onwards.

```go
type Request struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can embed this struct directly from the code https://github.com/filecoin-project/lotus/blob/master/chain/exchange/protocol.go#L48-L60 using https://github.com/filecoin-project/specs#embed

Example:

{{<embed src="https://github.com/filecoin-project/lotus/blob/master/chain/exchange/protocol.go" lang="go" symbol="Request" title="Exchange Protocol Request">}}

This way its easier to keep in sync.

@hugomrdias
Copy link
Contributor

Can you rebase please ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update blocksync section
4 participants