Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synthetic PoRep Actors and FVM integration #1711

Closed
cryptonemo opened this issue Jun 20, 2023 · 5 comments
Closed

Synthetic PoRep Actors and FVM integration #1711

cryptonemo opened this issue Jun 20, 2023 · 5 comments

Comments

@cryptonemo
Copy link
Collaborator

Description

The motivation for Synthetic PoRep is described in FIP-0059 (https://github.com/filecoin-project/FIPs/blob/master/FIPS/fip-0059.md) and code branches in Proofs exist and PRs are currently open:

#1701
filecoin-project/rust-filecoin-proofs-api#87
filecoin-project/filecoin-ffi#400

Acceptance criteria and Technical Scope

The remaining work required is updating the following repos:

https://github.com/filecoin-project/builtin-actors
https://github.com/filecoin-project/ref-fvm

With the new Proof types and tests (where applicable).

Where to begin

Related to the following:

filecoin-project/lotus#10984
filecoin-project/lotus#10970

@cryptonemo
Copy link
Collaborator Author

There are 4 repos with synthetic-porep branches in flight, required for this work:

https://github.com/cryptonemo/filecoin/tree/synthetic-porep
https://github.com/cryptonemo/builtin-actors-bundler/tree/synthetic-porep
https://github.com/cryptonemo/builtin-actors/tree/synthetic-porep
https://github.com/cryptonemo/ref-fvm/tree/synthetic-porep

The above build at the moment, but the patching mechanism was not working so all Cargo files were modified (not ideal). Looks like after yesterday, all of them need rebasing as well.

@jennijuju
Copy link
Member

patching mechanism was not working so all Cargo files were modified (not ideal)

can you elaborate?

@cryptonemo
Copy link
Collaborator Author

cryptonemo commented Jul 6, 2023

patching mechanism was not working so all Cargo files were modified (not ideal)

can you elaborate?

There are good ways to patch cargo dependencies into existing projects (in this case I want to pull in the synth porep branches), but I didn't have luck yet on getting the patches to work properly. So every reference to dependencies was updated manually, which is ugly and more work than necessary (in most cases). That will have to be resolved one way or another (perhaps new releases of dependencies, or some other way of getting it working). This is probably due mostly to me being unfamiliar with these repos and their almost circular dependency requirements 😵

Reference to patching: https://doc.rust-lang.org/cargo/reference/overriding-dependencies.html

@cryptonemo
Copy link
Collaborator Author

^To be clear, I'm not blocked on this, just working through it ...

@cryptonemo
Copy link
Collaborator Author

Completed

@github-project-automation github-project-automation bot moved this from In Review to Done in 🍉 nv21 - FilDev Track Board Sep 18, 2023
@rjan90 rjan90 moved this from In Progress to Done in 🍉 nv21 - FilDev Track Board Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

2 participants