-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synthetic PoRep Actors and FVM integration #1711
Comments
There are 4 repos with https://github.com/cryptonemo/filecoin/tree/synthetic-porep The above build at the moment, but the patching mechanism was not working so all Cargo files were modified (not ideal). Looks like after yesterday, all of them need rebasing as well. |
can you elaborate? |
There are good ways to patch cargo dependencies into existing projects (in this case I want to pull in the synth porep branches), but I didn't have luck yet on getting the patches to work properly. So every reference to dependencies was updated manually, which is ugly and more work than necessary (in most cases). That will have to be resolved one way or another (perhaps new releases of dependencies, or some other way of getting it working). This is probably due mostly to me being unfamiliar with these repos and their almost circular dependency requirements 😵 Reference to patching: https://doc.rust-lang.org/cargo/reference/overriding-dependencies.html |
^To be clear, I'm not blocked on this, just working through it ... |
Completed |
Description
The motivation for Synthetic PoRep is described in FIP-0059 (https://github.com/filecoin-project/FIPs/blob/master/FIPS/fip-0059.md) and code branches in Proofs exist and PRs are currently open:
#1701
filecoin-project/rust-filecoin-proofs-api#87
filecoin-project/filecoin-ffi#400
Acceptance criteria and Technical Scope
The remaining work required is updating the following repos:
https://github.com/filecoin-project/builtin-actors
https://github.com/filecoin-project/ref-fvm
With the new Proof types and tests (where applicable).
Where to begin
Related to the following:
filecoin-project/lotus#10984
filecoin-project/lotus#10970
The text was updated successfully, but these errors were encountered: