feat: charge explicit gas for batch verification #1854
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
commented
Aug 22, 2023
| @@ -27,6 +27,9 @@ use crate::kernel::SupportedHashes; | |||
| // https://docs.rs/wasmtime/2.0.2/wasmtime/struct.InstanceLimits.html#structfield.table_elements | |||
| const TABLE_ELEMENT_SIZE: u32 = 8; | |||
|
|
|||
| // Parallelism for batch seal verification. | |||
| const BATCH_SEAL_PARALLELISM: usize = 8; | |||
| verify_seal_base: Gas::new(2000), // TODO revisit potential removal of this | ||
| verify_seal_batch: ScalingCost { | ||
| flat: Gas::zero(), // TODO: Determine startup overhead. | ||
| scale: Gas::new(34721049), // TODO: Maybe re-benchmark? |
There was a problem hiding this comment.
Probably need to revisit/benchmark.
| .call_manager | ||
| .charge_gas(self.call_manager.price_list().on_batch_verify_seal(vis))?; | ||
|
|
||
| // TODO: consider optimizing for one proof (i.e., don't charge a batch overhead?) |
There was a problem hiding this comment.
This may not be necessary, it depends on the 'startup' overhead.
| let out = vis | ||
| .par_iter() | ||
| .map(|seal| { | ||
| match catch_and_log_panic("verifying seals", || verify_seal(seal)) { |
There was a problem hiding this comment.
do we want to allow partial success when called directly from the miner actor?
This won't currently make a difference on mainnet because we only call this from the cron actor (in an implicit message). However, we _will_ need this when we have the miner actor call it directly.
Stebalien
force-pushed
the
steb/charge-batch-verify
branch
from
3941f00
to
2f87cf9
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1854 +/- ##
==========================================
+ Coverage 75.32% 75.37% +0.05%
==========================================
Files 149 149
Lines 14568 14560 -8
==========================================
+ Hits 10973 10975 +2
+ Misses 3595 3585 -10
|
|
Closing in favor of #1882. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This won't currently make a difference on mainnet because we only call this from the cron actor (in an implicit message). However, we will need this when we have the miner actor call it directly.
fixes #1852