Event backpressure #251
Merged
Event backpressure #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matejpavlovic
force-pushed
the
event-backpressure
branch
from
3dc15d8
to
3357192
Compare
sergefdrv
approved these changes
Sep 30, 2022
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
This is necessary for the event processing backpressure to be effective. Otherwise, even though the event buffers would be limited, the batches of events passed to the modules for processing would continue exploding in size (up to, potentially, the size of the whole buffer). Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
matejpavlovic
force-pushed
the
event-backpressure
branch
from
8f834aa
to
a295218
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements backpressure for event processing within a node.
Active modules now cannot make the node's event buffers explode in size, as the node stops reading input from active modules when its internal event buffer grows above a configurable limit.
The limit on the internal event buffer is a "soft limit" in the sense that as long as there are fewer events than the limit in the buffer, an arbitrary event list can be added, which might result in the buffer's actual size "overshooting" the limit, if the event list being added is long. This should not be a big problem in practice though, as the list already occupies space in memory and the events are simply "moved" to the buffer, without creating another copy.
Resolves #100 .
Resolves #238 .