Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cli: print beneficiary info in state miner-info #9308

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

geoff-vball
Copy link
Contributor

Related Issues

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@geoff-vball geoff-vball requested a review from a team as a code owner September 14, 2022 05:08
@geoff-vball geoff-vball force-pushed the gstuart/beneficiary-info-cli branch from f6aac3a to 1122b04 Compare September 14, 2022 13:50
cmd/lotus-miner/info.go Outdated Show resolved Hide resolved
@geoff-vball geoff-vball force-pushed the gstuart/change-beneficiary branch from 0945e94 to d916f92 Compare September 14, 2022 17:37
@geoff-vball geoff-vball force-pushed the gstuart/beneficiary-info-cli branch 2 times, most recently from 1495eda to b0c2329 Compare September 14, 2022 18:21
@geoff-vball geoff-vball force-pushed the gstuart/change-beneficiary branch 2 times, most recently from 9e2fe56 to 84fd51f Compare September 14, 2022 20:52
Base automatically changed from gstuart/change-beneficiary to master September 14, 2022 21:47
@geoff-vball geoff-vball force-pushed the gstuart/beneficiary-info-cli branch from b0c2329 to 2d6d480 Compare September 14, 2022 21:52
@geoff-vball geoff-vball force-pushed the gstuart/beneficiary-info-cli branch from 2d6d480 to 9d63e14 Compare September 14, 2022 21:54
@arajasek arajasek merged commit 4e830a8 into master Sep 14, 2022
@arajasek arajasek deleted the gstuart/beneficiary-info-cli branch September 14, 2022 22:12
@jennijuju
Copy link
Member

Would loved some comment in code that it’s goanna be supported nv17 and up

@geoff-vball
Copy link
Contributor Author

@jennijuju In nv16 it won't print anything at all (so same behaviour until upgrade).

@jennijuju
Copy link
Member

jennijuju commented Sep 15, 2022

Yup I saw that in the code. Tho code comment is not for users, but developers. Any developer clone the lotus master/or merging lotus to their own fork today would thought this (beneficiary) is suppose to be a thing while it’s not, yet - so kinda confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants