From e4c890a93e9f1a8849a4969a42eaf23d577e30ae Mon Sep 17 00:00:00 2001 From: Rod Vagg Date: Tue, 11 Feb 2025 14:56:33 +1100 Subject: [PATCH 1/2] chore(test): skip unfixed flaky gateway limits test --- itests/gateway_test.go | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/itests/gateway_test.go b/itests/gateway_test.go index 94bd810d536..5b94d166aba 100644 --- a/itests/gateway_test.go +++ b/itests/gateway_test.go @@ -352,6 +352,12 @@ func sendFunds(ctx context.Context, fromNode *kit.TestFullNode, fromAddr address } func TestGatewayRateLimits(t *testing.T) { + t.Skip("this test is flaky and needs to be fixed") + // Fails on the RequireDuration check, e.g. error like: + // Max difference between 2025-02-10 12:05:34.63725116 +0000 UTC m=+30.240446844 and 2025-02-10 12:05:33.519935593 +0000 UTC m=+29.123131278 allowed is 800ms, but difference was 1.117315566s + // There may be additional calls going through the API that only show up at random and these + // aren't accounted for. See note below about paymentChannelSettler, which is one such call. + req := require.New(t) kit.QuietMiningLogs() From da0f88a4324c7600c4a2d80b0d6524d0d972b8cd Mon Sep 17 00:00:00 2001 From: Rod Vagg Date: Tue, 11 Feb 2025 17:03:56 +1100 Subject: [PATCH 2/2] Update itests/gateway_test.go --- itests/gateway_test.go | 1 + 1 file changed, 1 insertion(+) diff --git a/itests/gateway_test.go b/itests/gateway_test.go index 5b94d166aba..16945d3ff66 100644 --- a/itests/gateway_test.go +++ b/itests/gateway_test.go @@ -357,6 +357,7 @@ func TestGatewayRateLimits(t *testing.T) { // Max difference between 2025-02-10 12:05:34.63725116 +0000 UTC m=+30.240446844 and 2025-02-10 12:05:33.519935593 +0000 UTC m=+29.123131278 allowed is 800ms, but difference was 1.117315566s // There may be additional calls going through the API that only show up at random and these // aren't accounted for. See note below about paymentChannelSettler, which is one such call. + // Tracking issue: https://github.com/filecoin-project/lotus/issues/12566 req := require.New(t)