Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: release Lotus node & miner v1.31.0 #12735

Open
wants to merge 6 commits into
base: release/v1.31.0
Choose a base branch
from

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Nov 28, 2024

Related Issues

#12344

Proposed Changes

Publish stable release of v1.31.0.

Checklist

Before you mark the PR ready for review, please make sure that:

build: release Lotus node v1.31.0
chore: update changelog
@rjan90 rjan90 changed the title build: release Lotus node v1.31.0 build: release Lotus node & miner v1.31.0 Nov 28, 2024
@rjan90 rjan90 marked this pull request as ready for review November 28, 2024 20:06
Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog needs a bit of work, it's got some mistakes and omissions. Sorry I can't comment inline because the diff isn't close enough.

These are already in 1.30.0 so don't need to be noted in 1.31.0:

  • - Reduce size of embedded genesis CAR files by removing WASM actor blocks and compressing with zstd. This reduces the lotus binary size by approximately 10 MiB. ([filecoin-project/lotus#12439](https://github.com/filecoin-project/lotus/pull/12439))
  • - The mining loop will now correctly "stick" to the same upstream lotus node for all operations pertaining to mining a single block ([filecoin-project/lotus#12665](https://github.com/filecoin-project/lotus/pull/12665)).
  • - Event APIs (Eth events and actor events) should only return reverted events if client queries by specific block hash / tipset. Eth and actor event subscription APIs should always return reverted events to enable accurate observation of real-time changes. ([filecoin-project/lotus#12585](https://github.com/filecoin-project/lotus/pull/12585))
  • - Fix a bug in the lotus-shed indexes backfill-eventscommand that may result in either duplicate events being backfilled where there are existing events (such an operation *should* be idempotent) or events erroneously having duplicatelogIndex values when queried via ETH APIs. ([filecoin-project/lotus#12567](https://github.com/filecoin-project/lotus/pull/12567))

This one:

- The Lotus Miner will now always mine on the latest chain head returned by lotus, even if that head has less "weight" than the previously seen head. This is necessary because F3 may end up finalizing a tipset with a lower weight, although this situation should be rare on the Filecoin mainnet. ([filecoin-project/lotus#12659](https://github.com/filecoin-project/lotus/pull/12659))

Should probably also point to #12690 which is what actually got merged. Maybe just two links in there is fine.


These are missing and I think should be brought back in:

  • feat: return an error for null rounds from RPC methods #12655 Return a consistent error when encountering null rounds in ETH RPC method calls. ([filecoin-project/lotus#12655](https://github.com/filecoin-project/lotus/pull/12655)) (feature or bug fix, borderline call on that tbh)
  • fix: handle error and revert data in EthEstimateGas and EthCall #12553 - Return a "data"field on the"error"returned from RPC wheneth_callandeth_estimateGasAPIs encounterexecution reverted errors. This is a standard expectation of Ethereum RPC tooling and may improve compatibility in some cases. ([filecoin-project/lotus#12553](https://github.com/filecoin-project/lotus/pull/12553)) (I've extended the wording a bit, this is a new feature)

Here's my output of npx branch-diff origin/release/v1.30.0 origin/release/v1.31.0 --user filecoin-project --repo lotus --md along with some ticks for items that I see in the current changelog:

  • [7486f66978] - chore: go mod tidy (Phi)
  • [3f76743e8f] - chore: bump libp2p deps (Phi-rjan) #12729
  • ✅ [1476fbbdb7] - fix(miner): fix scary verified power miscalculation upon extension (ZenGround0) #12720
  • [c6e0637cab] - Skip checking the initial power table CID if undefined (Masih H. Derkani) #12725
  • [4a10225e0f] - docs: replace more references to lotus-shed with lotus in ChainIndexer docs (Rod Vagg) #12708
  • [1e4150fbf2] - Use DEBUG level log when F3 is not ready for participation (Masih H. Derkani) #12700
  • ✅ [ce4c03dd39] - feat: implement F3 CLI to list power table and proportional power at instance (Masih H. Derkani) #12698
  • [c882d9f82a] - Fix missing flag for lotus-shed datastore import (Masih H. Derkani) #12695
  • [b28773db6d] - Fix minor bugs in lotus shed datastore subcommand (Masih H. Derkani) #12694
  • ✅ [5a4d6a9397] - chore(events): improve perf for parallel event filter matching (Rod Vagg)
  • [6cd7982590] - build: release Lotus node v1.31.0-rc1 (Phi-rjan) #12693
  • ✅ [3d0112e471] - fix(miner): ignore lastWork when selecting the best mining candidate (Jakub Sztandera) #12690
  • [ffe5b28080] - chore(deps): switch to the stdlib atomic package in snapshot code (Steven Allen) #12666
  • [9300855ce5] - chore: bump filecoin-ffi to v1.31.0-rc1 (Phi-rjan) #12687
  • [b89a29803b] - feat(shed): add commands for importing/exporting datastore snapshots (Steven Allen) #12685
  • [4eb45ca011] - docs: update references for lotus-shed chainindex to lotus index (Viraj Bhartiya) #12684
  • [99cf23278a] - build: release Lotus node|miner v1.30.0 (build: release Lotus node|miner v1.30.0  #12678) (Phi-rjan) #12683
  • [e9393dfe8c] - fix(eth): present revert "data" as plain bytes (Rod Vagg)
  • [f0f5c7663b] - feat(cli): move chainindex cmd from lotus-shed to lotus (Viraj Bhartiya) #12668
  • [a4a7cbe07a] - fix(ci): fetch tags (Steven Allen) #12679
  • ✅ [3a3483206b] - fix(events): order events consistently when querying (Rod Vagg)
  • ✅ [dcc903c65d] - feat: a new ChainIndexer to index tipsets, messages and events (Aarsh Shah) #12657
  • [6a70c6b01b] - feat(eth): return consistent error for null rounds from RPC methods (Viraj Bhartiya) #12655
  • ✅ [04d31d3b50] - fix(miner): use the "from" address as the sender if it is set (asamuj) #12662
  • [cfde1d563f] - chore(deps): update poseidon to the released version (Steven Allen) #12656
  • [2b7f595fa5] - test(chain): test forking before/after finality (Steven Allen) #12652
  • [dc3a3d3e98] - fix(test): address minor lint issue (Rod Vagg) #12645
  • [29a131ca0d] - test(eth): fix bloom filter test flake (Steven Allen) #12643
  • [cc718fbf8e] - test(eth): fix execution/inclusion off-by-one (Steven Allen) #12642
  • ✅ [ab3446726f] - feat(eth): implement eth_getTransactionByBlockNumberAndIndex and eth_getTransactionByBlockHashAndIndex (Viraj Bhartiya) #12618
  • [082b7caab5] - feat(api): populate data field for revert error in EthEstimateGas and EthCall (Viraj Bhartiya) #12553
  • [de18fcf2db] - feat(f3): lotus shed command to delete all f3 state (Steven Allen) #12638
  • [c6fdf956c5] - chore: update network skeleton docs (Krishang Shah) #12631
  • [02a8b972db] - chore(logging): downgrade GasEstimateMessageGas info log to debug (Rod Vagg)
  • [df35dc1bc5] - fix(f3): correctly construct the manifest template (Steven Allen) #12628
  • [bc8c29bf7f] - feat(f3): display the initial power table CID in the F3 manifest (Steven Allen) #12626
  • [7c0c493861] - chore(ci): allow ', ", ` characters to prefix commit description (Rod Vagg)
  • ✅ (rm) [dafc56c805] - feat(events): compare-amt option for lotus-shed indexes inspect-events (Rod Vagg) #12571
  • ✅ [d516f3aaa8] - feat(cli): lotus chain head --height to print epoch number (Rod Vagg)
  • [50f72ed0e3] - chore(spcli): improve sectors extend sector skipping info logging (Rod Vagg)
  • [a89cf6d1c0] - test: disable NAT port mapping, outbound dials, inbound connections (Steven Allen) #12591
  • [9f06b8bde7] - Reduce verbosity of F3 logs during itest (Masih H. Derkani) #12596
  • ✅ [f6d4fc7ccb] - fix(lotus-shed): improve termination-estimate CLI for delegated owner addresses (Danial Ahn) #12569
  • [4cd4600f76] - build: update Node and Miner version to v1.30.1-dev in master (Phi-rjan) #12562
  • [ba17b9acd2] - fix(f3): use the correct context in tests (Steven Allen) #12582

@rvagg
Copy link
Member

rvagg commented Nov 29, 2024

FYI what's left on master:

npx branch-diff origin/release/v1.31.0 origin/master --user filecoin-project --repo lotus --md
  • [e994e9566c] - fix: use numerical formatting when printing F3 CLI error message (Masih H. Derkani) #12739
  • [64736eaab0] - feat: api: market pending proposal API/CLI (Łukasz Magiera) #12724
  • [bb7e62dd5a] - chore(docs): fix mismatched godoc method names (huajin tong) #12736
  • [a4cd57eff3] - feat(f3): tool for explicit power table generation (Jakub Sztandera) #12723
  • [5791b4a978] - feat(shed): check command for FIP-0081 pledge calculation (Rod Vagg)
  • [b0de2bd64b] - feat: nv25 network skeleton (Krishang Shah) #12707
  • [0d1d7c29c2] - chore: fix function name (chuangjinglu) #12716
  • [e2c46f1af1] - chore(test): minor cleanup and debugging output for TestEthBlockHashesCorrect_MultiBlockTipset (Rod Vagg)
  • [9548629e2f] - feat(shed): lotus-shed sectors dump-sectors (Rod Vagg) #12703
  • [f4dbd88f45] - fix: ChainIndexer#GetMsgInfo returns an ErrNotFound when there are no rows (Viraj Bhartiya) #12680
  • [467c6ff63d] - chore(deps): adapt to QAP API changes (Rod Vagg)
  • [4f923484bd] - feat(events): add max results error and default raw codec for eth_getLogs (Aryan Tikarya) #12671
  • [1f5f51fc38] - doc(indexer): more clarity for ChainIndexer configuration setup (Rod Vagg) #12701
  • [8003997b85] - fix(eth): make trace_filter resilient to null rounds (Rod Vagg) #12702
  • [c0ec481438] - fix(test): unflake TestEthBlockNumberAliases (Rod Vagg) #12699
  • [3f31b3b423] - chore: fix struct name in comment (pinglanlu) #12689
  • [6b4cc35836] - build: update Lotus Node & Miner version to v1.31.1-dev in master (Phi-rjan) #12692

A little sad that some of them will have to wait, but they're not urgent I think and I imagine a 1.31.1 soon that can take them.

chore: remove already released PRs from v1.31.0 changelog
Add link to the PR that actually got merged.
chore: add missing entries that should be highlighted
@rjan90
Copy link
Contributor Author

rjan90 commented Nov 29, 2024

Thanks for the thorough review @rvagg. I have pushed three commits that should address the changes you highlighted:

  • Remove already released PRs from the v1.31.0 changelog: 698b3c0
  • Add additional link to the PR that actually got merged for the Lotus-Miner bugfix: a2aae9a
  • Add missing entries that should be highlighted: 6e14943

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Rod Vagg <[email protected]>
@@ -2,9 +2,9 @@

# UNRELEASED

# Node and Miner v1.31.0-rc1 / 2024-11-12
# Node and Miner v1.31.0 / 2024-11-28
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Node and Miner v1.31.0 / 2024-11-28
# Node and Miner v1.31.0 / 2024-11-29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✔️ Approved by reviewer
Development

Successfully merging this pull request may close these issues.

3 participants