Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: test: Add more post-migration sanity checks #11168

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

arajasek
Copy link
Contributor

Related Issues

This builds on #11149 to add a few more "vanilla" sanity checks that always apply

Proposed Changes

Check that:

  • system actor is now v12
  • the Manifest stored in the system actor state matches what Lotus expects

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@arajasek arajasek requested a review from a team as a code owner August 14, 2023 21:18
@snissn
Copy link
Contributor

snissn commented Aug 14, 2023

looks great!

snissn
snissn previously approved these changes Aug 14, 2023
Copy link
Contributor

@snissn snissn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@snissn snissn dismissed their stale review August 14, 2023 21:30

ci failed

@snissn
Copy link
Contributor

snissn commented Aug 14, 2023

Hi! I had approved this pr conditional on the checks passsing, and unfortuantely there's some style checks that are failing here

@arajasek arajasek force-pushed the asr/more-migration-check branch from e69b1be to e6b0231 Compare August 14, 2023 22:11
@arajasek arajasek changed the title Add more post-migration sanity checks feat: test: Add more post-migration sanity checks Aug 14, 2023
@arajasek
Copy link
Contributor Author

Merging, test is failing on base branch too.

@arajasek arajasek merged commit 1eec816 into feat/nv21-skeleton Aug 17, 2023
@arajasek arajasek deleted the asr/more-migration-check branch August 17, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants