Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a cli for ChangeBeneficiary #9254

Closed
jennijuju opened this issue Sep 2, 2022 · 4 comments · Fixed by #9307
Closed

Add a cli for ChangeBeneficiary #9254

jennijuju opened this issue Sep 2, 2022 · 4 comments · Fixed by #9307
Assignees
Labels
P1 P1: Must be resolved
Milestone

Comments

@jennijuju
Copy link
Member

jennijuju commented Sep 2, 2022

related #9253

I think for a better user experience, we should have to CLI

  • lotus-miner actor propose-change-beneficiary
    • fail early if the caller is not the owner
    • should show if its a replacement of a pendingchange
    • we should handle the situation when the owner is a msig
  • lotus-miner actor confirm-change-beneficiary
    • fail early if the caller is not the new beneficiary or the existing beneficiary
  • we should create tooling for performing this action via msig (this can be a separate issue later)
@jennijuju jennijuju added P1 P1: Must be resolved FIP-0029 labels Sep 2, 2022
@jennijuju
Copy link
Member Author

jennijuju commented Sep 2, 2022

@geoff-vball please review the scope and adjust the estimation accordingly (if we are doing msig in a later issue - then the estimation should go down to <8 imho)

@jennijuju jennijuju moved this to Opportunistic in Network nv17 Sep 2, 2022
@jennijuju jennijuju added this to the Network v17 milestone Sep 2, 2022
@geoff-vball
Copy link
Contributor

Msig tooling definitely shouldn't be in this ticket. I'd argue we might not want it at all? @arajasek

@arajasek
Copy link
Contributor

arajasek commented Sep 11, 2022

Let's do both accounts and multisigs as part of this ticket. We just have to build off the existing change-worker functionality, which makes this very easy.

@geoff-vball
Copy link
Contributor

@arajasek I'm super duper confused at the workflow for actorProposeChangeWorker and actorConfirmChangeWorker. Propose sends a message signed by the owner key with a new worker address. Then Confirm sends a message with no params, also signed by the owner address. I don't understand the point of this. It would make sense to me that that message would be signed by the new worker address.

Repository owner moved this from Opportunistic to Done in Network nv17 Sep 14, 2022
@jennijuju jennijuju mentioned this issue Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 P1: Must be resolved
Projects
No open projects
Status: Done
3 participants