Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose mechanism to DeclareFaultsRecovered manually #7748

Closed
5 of 14 tasks
jennijuju opened this issue Dec 10, 2021 · 2 comments · Fixed by #9144
Closed
5 of 14 tasks

Expose mechanism to DeclareFaultsRecovered manually #7748

jennijuju opened this issue Dec 10, 2021 · 2 comments · Fixed by #9144
Assignees
Labels
dif/easy An existing lotus user should be able to pick this up effort/hours Effort: Hours impact/new-api kind/feature Kind: Feature P3 P3: Might get resolved

Comments

@jennijuju
Copy link
Member

Checklist

  • This is not a new feature or an enhancement to the Filecoin protocol. If it is, please open an FIP issue.
  • This is not brainstorming ideas. If you have an idea you'd like to discuss, please open a new discussion on the lotus forum and select the category as Ideas.
  • I have a specific, actionable, and well motivated feature request to propose.

Lotus component

  • lotus daemon - chain sync
  • lotus miner - mining and block production
  • lotus miner/worker - sealing
  • lotus miner - proving(WindowPoSt)
  • lotus miner/market - storage deal
  • lotus miner/market - retrieval deal
  • lotus miner/market - data transfer
  • lotus client
  • lotus JSON-RPC API
  • lotus message management (mpool)
  • Other

What is the motivation behind this feature request? Is your feature request related to a problem? Please describe.

after faulting a sector, most of the time it takes SP less than 24 hours to recover the sector. As soon as they've done that, they should be able to manually declare the sector to be recovered .

Describe the solution you'd like

expose an api to call DeclareFaultsRecovered

have a cli like lotus-miner proving declare-recovery [sector id1........sector idN]

Describe alternatives you've considered

No response

Additional context

No response

@jennijuju jennijuju added kind/feature Kind: Feature need/triage impact/new-api P3 P3: Might get resolved dif/easy An existing lotus user should be able to pick this up effort/hours Effort: Hours and removed need/triage labels Dec 10, 2021
@jennijuju
Copy link
Member Author

add api to lotus example https://github.com/filecoin-project/lotus/pull/6642/files

after adding this, run make gen will generate the api docs

@geoff-vball geoff-vball self-assigned this Dec 10, 2021
@Aloxaf
Copy link
Contributor

Aloxaf commented Dec 23, 2021

Is there any advantage to declare recovered as soon as sectors are recovered? As I understand, WindowPost will not be submitted and SP's power won't be recovered, until the deadline is reached.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dif/easy An existing lotus user should be able to pick this up effort/hours Effort: Hours impact/new-api kind/feature Kind: Feature P3 P3: Might get resolved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants