Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mechanism to start push / pull channel data rate monitoring #172

Closed
dirkmc opened this issue Mar 23, 2021 · 1 comment
Closed

Add mechanism to start push / pull channel data rate monitoring #172

dirkmc opened this issue Mar 23, 2021 · 1 comment
Labels
x/ignite Issues and PRs being tracked by Team Ignite at Protocol Labs

Comments

@dirkmc
Copy link
Contributor

dirkmc commented Mar 23, 2021

Currently the push or pull channel data rate monitoring starts automatically when the channel is opened.

However in go-fil-markets for retrieval we open a pull channel, then create a payment channel. It can take a long time to open a payment channel which means the data-rate will be zero, and the pull channel monitor will try to restart the connection.

Instead we should add a mechanism to manually start data-rate monitoring at some point after the channel has been opened.

@dirkmc
Copy link
Contributor Author

dirkmc commented May 6, 2021

Fixed by filecoin-project/go-fil-markets#540

@dirkmc dirkmc closed this as completed May 6, 2021
@dkkapur dkkapur added this to the 🤝 Deal Success milestone May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x/ignite Issues and PRs being tracked by Team Ignite at Protocol Labs
Projects
None yet
2 participants