Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filscanteam allocator application #175

Closed
FilscanOfficial opened this issue Sep 25, 2024 · 9 comments
Closed

filscanteam allocator application #175

FilscanOfficial opened this issue Sep 25, 2024 · 9 comments

Comments

@FilscanOfficial
Copy link

Allocator application filecoin-project/notary-governance#1033

Our first batch of 5PiB is about to be consumed, and we hope to apply for another 10PiB to solve the DC needs of the first round of customers and new customers. Thank you very much.

@filecoin-watchdog
Copy link

filecoin-watchdog commented Oct 1, 2024

Allocator Application
Compliance Report

Example 1
Client said this project is associated with other projects/ecosystem stakeholders, yet didn't say which ones and allocator didn't follow on that up.
The data sample was not reviewable, so how did the allocator do a compliance check on that?
The retrieval rate of this client is not tragic, yet it could be better—with 5 SPs, it oscillates between 36% and 90%.

This GitHub issue was closed by the allocator's client.

Example 2
1st CID Report was run after the third allocation. How did the allocator do the diligence check if no reports were run before?
After the first check, it turned out that CID sharing occurred. After following up with the client, they answered that they didn’t know how that was possible.
A little investigation showed this was the allocator of wushen. Gov team should follow up on this.
It’s not a coincidence that some piece of data are exactly the same (it’s not a big amount though - ~400TiB).
In addition, 3 out of 5 SPs have no retrieval rate, and the other 2 have a retrieval rate below 20%.

Example 3
Even though unclear situations with the client of Example 2 were not properly clarified, the allocator agreed to continue cooperating, and due to some technical issues, they opened another application.
Considering that issues 9 and 17 involved the same client, I may assume that the total DC requested was 3 PiB, and this client already received more than that (~3.5 PiB). Why would the allocator consider granting another tranche?
The client provided a retrieval rate written in an Excel file and screenshots, explaining that SPs are using DDO. To say that delicately it’s not a proper way to prove a retrieval rate.
The retrieval rate of SPs and SPs themselves is precisely the same as in Example 2, so I won’t repeat it.

@Kevin-FF-USA
Copy link
Collaborator

Hi @FilscanOfficial,

Wanted to bubble this issue up to ensure you saw the questions posed by the Watchdog.

@FilscanOfficial
Copy link
Author

@Kevin-FF-USA
Thank you for your reminder. It is my responsibility to supervise and review. I am willing to cooperate and explain.
@filecoin-watchdog

FilscanOfficial/filscan-backend#4

  1. I am sorry that this is my first client and I was careless and did not notice this problem. After you raised this question, I asked the client and he answered it. In fact, he misunderstood the concept of stakeholders and checked the wrong one. I will pay close attention to this in subsequent audits and will not make similar situations again.
    image

  2. His data samples are auditable, and I have checked them before assigning them. The following is an example of their public data.
    image
    image

FilscanOfficial/filscan-backend#9
FilscanOfficial/filscan-backend#17

  1. FileDrive Labs is also one of the ecosystem builders of filecoin. We have always maintained a good communication relationship offline. We have sufficient understanding and trust in them. We have also communicated with them offline and they meet the requirements. When problems were found in the CID report, we also began active communication and problem troubleshooting. In the subsequent distribution, I will also pay more attention to this point, and each round of distribution will be more strict.
  2. Regarding the retrieval rate, we have confirmed that the three nodes without retrieval are DDO nodes. My understanding is that the distributor supports DDO. As for when DDO can verify the retrieval rate, we are also waiting for the progress of this proposal. If there is any better verification method at this stage, I hope you can give me some guidance. Thank you very much!
    DDO Compatibility: IPNI Reverse Index and related features space-meridian/roadmap#147

As an allocator, I may still have various shortcomings in the first round of approval, but through this round of practice and continuous learning, I will strictly abide by the regulations of the Filecoin network in future allocations, continuously monitor the performance of storage providers, grasp the approval standards, and do this job better and better. Thank you to the filecoin team for their efforts, let us work together!

@FilscanOfficial
Copy link
Author

@filecoin-watchdog
Sorry, I missed a question. The reason why the customer applied for 3PiB and finally provided 3.5PiB was that when the customer was about to use up all the space, he hoped to apply for another 1PiB. At that time, I only had 500TiB left. I thought I could do it this way, so I didn't let him reapply. I will also make improvements on this in the future allocation process.

image
image

@filecoin-watchdog
Copy link

@FilscanOfficial

I thought I could do it this way, so I didn't let him reapply.

For the future, a change request might have sufficed. You don't have to advise your clients to open another application when more DC needs to be distributed, new replicas, new SPs, etc. However, you should pay attention to keeping the application up to date.

@FilscanOfficial
Copy link
Author

@filecoin-watchdog
Got it. I'll be on the lookout for app updates in future missions,thank you.

@galen-mcandrew
Copy link
Collaborator

Based on the investigation and details provided, we are seeing mixed compliance results. Some areas for this allocator to focus on should include:

  • Verifying public client application details in GitHub, and providing diligence evidence for future bookkeeping investigations
  • SP lists before and after allocations, with explanations from clients when there are changes made
  • Continuing to improve retrieval rates

Given this review, we are requesting that the allocator verify that they will uphold all aspects & requirements of their initial application, with some extra focus on these areas. If so, we will request an additional 5PiB of DataCap from RKH, to allow this allocator to show increased diligence and alignment.

@FilscanOfficial
Copy link
Author

@galen-mcandrew
Thank you for your reply. I will pay close attention to and ensure the compliance of subsequent customers and the above issues. I wish you a happy work!

@Kevin-FF-USA Kevin-FF-USA added Diligence Audit in Process and removed Awaiting Response from Allocator Further information is requested labels Oct 24, 2024
@Kevin-FF-USA
Copy link
Collaborator

DataCap has been refilled.
https://datacapstats.io/notaries/f03019853

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants