Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Community Review of Venus Fil+ Datacap Allocator (VFDA) #149

Closed
VenusOfficial opened this issue Aug 31, 2024 · 6 comments
Closed

Community Review of Venus Fil+ Datacap Allocator (VFDA) #149

VenusOfficial opened this issue Aug 31, 2024 · 6 comments

Comments

@VenusOfficial
Copy link

VenusOfficial commented Aug 31, 2024

Allocator Application filecoin-project/notary-governance#1035

As the owner of the Venus official account, we are dedicated to serving the community through our allocator. However, we must admit that we initially struggled to balance the quantity of clients with the quality of data. Recognizing these challenges, we have reallocated more resources to enhance the DC distribution process. We have implemented stricter KYB and KYC processes for DC applications, addressing data sharing issues among different clients. Regarding data retrievability, we have communicated with the Venus development team to drive the implementation of SPARK support in the Venus Droplet function. We are also in touch with the SPARK team to understand the timeline for the availability of retrievability for DDO, expected in September or October this year.

We acknowledge the difficulty of maintaining both high quality and high quantity simultaneously. After learning from the first round of DC distribution, we are confident in our performance for the next round of DC replenishment. To continue our support and commitment to the community, we sincerely apply for 10 PiB DC in this round.

@filecoin-watchdog
Copy link

Allocator Compliance Report: https://compliance.allocator.tech/report/f03019831/1726185759/report.md

Example 1
Allocator claimed the cheating closed client’s application, gov team should follow up.

Example 2
The allocator closed the application without additional explanation while the client still had DC to spend. They explained themselves after a follow-up question that they had discussed with the client offline. The gov team should follow up.

Example 3
The allocator closed the application due to never using the DC. Should DataCap be revoked?

Example 4
The allocator granted DC before asking for KYB.
Gave 200TiBs and then found CID issues.

SPs provided:
f01114587
f02002888
f02003866
f02003888
f0522948
f0867300
f01228008
f01228000
f02002288
f02104858
F02006999

SPs used for deals:
f02894286Seoul, Seoul, KR
f02870401Jakarta, Jakarta, ID
SPs do not match. Retrieval rate below 1%.

Example 5
Private Commercial/Enterprise
No KYB process is documented.
SPs were being updated several times.

CID report: https://check.allocator.tech/report/VenusOfficial/Pathway-VFDA/issues/22/1722942268616.md

SPs provided:
1,f03136895 Virginia, USA,
2,f03087482 Virginia, USA
3,f03106356 Virginia, USA,
4,f02894286 Seoul, South Korea
5,f01100139 Japan

SPs used for deals:
f02894286Seoul, Seoul, KR
f02870401Jakarta, Jakarta, ID

1 of 2 SPs doesn’t match the original list.

Example 6
The client asked for 2 PiBs, but the allocator agreed to grant only 1 PiB. The application closed after using all DC.

Across all applications no KYC process is documented (no KYB for private commercial/enterprice in example 5). Allocator says they are doing KYC/KYB through the meetings, Gov team should follow up.
Only 4 out of 9 Allocator’s clients have run the CID checker report. If the allocator doesn’t use these reports, how do they conduct diligence checks?
Only 1 out of 37 SPs has a retrieval rate of over 20%.
The allocator was declared to use only clients and SPs in Asia, while they have clients from America.
Clients #22 and #40 are the same clients - why separate applications? Gov team should follow up.

@VenusOfficial
Copy link
Author

VenusOfficial commented Sep 14, 2024

@filecoin-watchdog
First of all, thank you very much for the comments. Here are some explanations.
Example 1
Q: Allocator claimed the cheating closed client’s application, gov team should follow up.
A: After performing the DataCap and CID Check Report, we provided the following comments:
图片

Example 2
Q: The allocator closed the application without additional explanation while the client still had DC to spend. They explained themselves after a follow-up question that they had discussed with the client offline. The gov team should follow up.
A: The application was closed earlier due to data issues with this client. We agreed with the client offline to close the application.

图片

Example 3
Q: The allocator closed the application due to never using the DC. Should DataCap be revoked?
A: It would be helpful if someone could explain how to revoke unused DataCap. From our understanding, unused DataCap is automatically revoked after 80 days.

Example 4
Q: The allocator granted DC before asking for KYB.
Gave 200TiBs and then found CID issues.
SPs provided:
f01114587
f02002888
f02003866
f02003888
f0522948
f0867300
f01228008
f01228000
f02002288
f02104858
F02006999
SPs used for deals:
f02894286Seoul, Seoul, KR
f02870401Jakarta, Jakarta, ID
SPs do not match. Retrieval rate below 1%.
A: We added those two SPs to the list after identifying the issue.
图片

A: Regarding the low retrieval rate, we are continuing to follow up with them as outlined below. Apologies, the details are in Chinese. They mentioned that they are unsure why the retrieval rate is so low, even though the data is present.

图片
图片

Example 5
Q: Private Commercial/Enterprise
No KYB process is documented.
A: KYB was conducted on #20, which is for the same client.
图片

SPs were being updated several times.
CID report: https://check.allocator.tech/report/VenusOfficial/Pathway-VFDA/issues/22/1722942268616.md
SPs provided:
1,f03136895 Virginia, USA,
2,f03087482 Virginia, USA
3,f03106356 Virginia, USA,
4,f02894286 Seoul, South Korea
5,f01100139 Japan
SPs used for deals:
f02894286Seoul, Seoul, KR
f02870401Jakarta, Jakarta, ID
1 of 2 SPs doesn’t match the original list.
A: Example 4 and 5 are for the same client.
Example 6
Q: The client asked for 2 PiBs, but the allocator agreed to grant only 1 PiB. The application closed after using all DC.
A: We agreed with the client offline that they didn't need additional DataCap.

Q: Across all applications no KYC process is documented (no KYB for private commercial/enterprice in example 5). Allocator says they are doing KYC/KYB through the meetings, Gov team should follow up.
A: The issue is improved after our acknoledgement. Following are some samples of KYCs:
#20:
图片
图片

#22:

图片

#24:

图片

#40:
图片

Q: Only 4 out of 9 Allocator’s clients have run the CID checker report. If the allocator doesn’t use these reports, how do they conduct diligence checks?
A: We verify compliance at compliance.allocator.tech.
Only 1 out of 37 SPs has a retrieval rate of over 20%.
A: We checked those with a low retrieval rate and assumed that those with a rate of 0 had used DDO.

Q:The allocator was declared to use only clients and SPs in Asia, while they have clients from America.
A: We believe that America might be categorized under OTHER regions as declared in our application.

  1. Region(s) of operation:
    Asia minus GCR, Greater China, Japan, Other

Q:Clients #22 and #40 are the same clients - why separate applications? Gov team should follow up.
A: The reason the client has two separate applications is due to a misunderstanding of the audit request. We thought it would be clearer to separate the application with different issue number.

@VenusOfficial
Copy link
Author

@Kevin-FF-USA
I already responded on September 14. Could you please check? Thank you.

@Kevin-FF-USA Kevin-FF-USA added Diligence Audit in Process and removed Awaiting Response from Allocator Further information is requested labels Sep 23, 2024
@galen-mcandrew
Copy link
Collaborator

Responding to some of the above comments:

Example 3: It would be helpful if someone could explain how to revoke unused DataCap. From our understanding, unused DataCap is automatically revoked after 80 days.

DataCap is NOT automatically revoked. The FIDL team has been working to create a front-end tool for removing DataCap from a client. This flow kicks off two bot 'notary' messages on-chain, but still requires the Gov Team and RKH to review and sign-off on the removal. There is also work being done with the new "meta-allocator" structure, where allocators would have more controls over DataCap given to clients; specifically, an ability for the allocator to revoke DataCap they issued to a client WITHOUT involving a second allocator/RKH.

Overall, there is good acknowledgement of the issues, with some clear evidence of allocator interventions for clients that are not following best practices. This type of intervention, with the allocator reviewing and closing out applications, is a good sign. However, we would like to see some additional standardization of the diligence and KYC process. Going forward, we hope to see additional evidence of data distribution and retrieval standards.

Given the diligence evidence and retrieval we are seeing, we are requesting an additional 5 PiB of DataCap from RKH to support this allocator increasing their compliance and alignment.

@VenusOfficial
Copy link
Author

@galen-mcandrew
Thank you for the instructions on DC revocation and your comments on compliance. We look forward to trying the new "meta-allocator" for all its functions. We will continue to improve our performance in the areas emphasized in your feedback.

@Kevin-FF-USA
Copy link
Collaborator

DataCap has been refilled.
f2hxivxs3we5afsuyx32lwwn44evopz7yea2fsmhy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants