-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FileUpload disk attribute is ignored #14503
Comments
@mrvnklm Hi there, I can't seem to be able to reproduce the issue, but just to clear things up, if you try creating a user in the repository you provided, both the files get uploaded to the public folder? |
@balintxd yes thats right, i did not figure out why this happens |
any solution here? |
are you having the same issue? seems weird, that no one has reported this so far as this is a pretty severe bug. |
I success to upload it to my S3 minio. But there is no preview when editing. idk |
that might have to do with the visibility and url generation of the s3 file, set |
|
Forms\Components\FileUpload::make('image')
->disk('s3')
->directory('banners')
->previewable()
->visibility('private')
->required(), like this? still not work |
the solution in my case, just make it so that it doesn't just take the file information Forms\Components\FileUpload::make('image')
->disk('s3')
->directory('banners')
->fetchFileInformation(false) // <--- this
->previewable()
->required(), but still, this needs a better solution in the future My case: uploaded successfully but the preview doesn't appear |
Package
filament/filament
Package Version
latest
Laravel Version
11.23.5
Livewire Version
No response
PHP Version
8.3.11
Problem description
FileUpload::make('original')->disk('local')
is ignored. it uses laravelsfilesystems.php
default and also ignores thedefault_filesystem_disk
infilament.php
configExpected behavior
to change disk by using
->disk()
Steps to reproduce
set
->disk()
to anything different than your configured laravel defaultjust create "new user" in test repo and see both uploads succeed even though no s3 credentials are set
Reproduction repository (issue will be closed if this is not valid)
https://github.com/mrvnklm/filament-upload-bug
Relevant log output
No response
Donate 💰 to fund this issue
The text was updated successfully, but these errors were encountered: