-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Types + Variable Resolver #272
Conversation
…ations. updated docs. Fixes detecting cycles in graphs. Fixes fidelity#260 and issues with Tuples enforcing len and checking type. bumped black support for 3.10. added pre-commit hooks. updated linter.
…ss). swapped to direct type declaration for file and directory as subclasses of str
Pull Request Test Coverage Report for Build 3912745148Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
@brianwarner Need reviewer approval for merge to master. Also can't cut a new release via a tag (which will trigger the build/push to pypi) since I don't have permissions. This should be the 3.0 release as there is a non backwards compat feature. Any chance you've figured out Fidelity's view on outside collaborators being able to review/merge/release? Need a path to sustainability here as I've picked back up development... Trying to avoid forking spock and maintaining it outside of Fidelity OSS |
…ences. more graphs to the rescue. added unit tests
What does this PR do?
${spock.var:SpockClass.defined_variable}
. Closes Interpolation and Accessing environment variables and other resolvers inside the config.yaml similar to OmegaConf #243List
of repeated@spock
decorated classes.Checklist