Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set observedGeneration under condition Ready #209

Closed
kishoregv opened this issue Jun 14, 2021 · 1 comment
Closed

Set observedGeneration under condition Ready #209

kishoregv opened this issue Jun 14, 2021 · 1 comment

Comments

@kishoregv
Copy link

Is your feature request related to a problem? Please describe.
Currently, observedGeneration is only set in status level for al resource. It would be helpful to set observedGeneration under conditions as well. To reliably rely on kubectl wait command for ready condition to be met.

If the previous condition was ready for HR resource then, sometime kubectl wait will confirm to soon as condition met based on previous Ready condition.

Describe the solution you'd like
observedGeneration should be set under condition.

Describe alternatives you've considered
We have are sleeping for 30 secs hoping the status will be updated in the mean time.

@wangli1030
Copy link
Contributor

Has been implemented by PR #226

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants