Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: the AWS SAML service provider should use the resolve package #188

Open
richardcase opened this issue Nov 13, 2020 · 0 comments
Open

Refactor: the AWS SAML service provider should use the resolve package #188

richardcase opened this issue Nov 13, 2020 · 0 comments
Labels
area/cli Related to the CLI plumbing help wanted Extra attention is needed kind/feature A new feature request priority/backlog Higher priority that awaiting-more-information. This issue is on the backlog for future development.
Milestone
Future

Comments

@richardcase
Copy link
Contributor

Describe the solution you'd like:
After 0.3 is released we should refactor the AWS service provider (SAML) so that it uses the resolve package.

https://github.com/fidelity/kconnect/blob/main/pkg/plugins/identity/saml/sp/aws/resolver.go

Why do you want this feature:
To reduce the duplicate code and take advantage of centrally adding custom filters etc

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
@richardcase richardcase added help wanted Extra attention is needed kind/feature A new feature request priority/backlog Higher priority that awaiting-more-information. This issue is on the backlog for future development. area/cli Related to the CLI plumbing labels Nov 13, 2020
@richardcase richardcase added this to the Future milestone Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/cli Related to the CLI plumbing help wanted Extra attention is needed kind/feature A new feature request priority/backlog Higher priority that awaiting-more-information. This issue is on the backlog for future development.
Projects
None yet
Milestone
Future
Development

No branches or pull requests
1 participant
@richardcase