Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Wave effect when you scroll (touch) #89

Closed
polikin opened this issue Feb 5, 2015 · 13 comments
Closed

Disable Wave effect when you scroll (touch) #89

polikin opened this issue Feb 5, 2015 · 13 comments
Labels
Milestone

Comments

@polikin
Copy link

polikin commented Feb 5, 2015

When you scroll down/up, the effect is call everytime you "click -> scroll" over the element. It is possible to disable the effect onScroll?

http://screencast-o-matic.com/u/VAds/waves

@hoxxep
Copy link
Contributor

hoxxep commented Feb 14, 2015

This would be quite difficult to fix, because Waves has to bind touch events. If we had to wait to check whether the user has touched or scrolled, the effect isn't quite as clean. The effect fires before the scroll, so disabling it while the user is scrolling has no impact. In all honesty, it doesn't look overly bad nor impact an application's function.

We could try to use fastclick and only fire waves on touch-up events if the user hasn't moved the touch more than x number of pixels, but this means that waves can't appear during touch-and-hold events.

I think this depends on which compromise we prefer, and the touch-and-hold is potentially a more important scenario (showing the user is pressing an element), and rippling during touch-scrolling isn't a bad scenario (showing the user has touched/skimmed over an element).

Personally, I think this is a wontfix "bug"; the user has touched the element, so like water whether you touch or skim over the surface, it's possible to counter-argue that it should ripple anyway. Does that make sense?

@fians
Copy link
Owner

fians commented Mar 4, 2015

I will try to find a way how to fix this.

@fians fians added the Bug label Mar 4, 2015
@fians fians added this to the v0.7.0 milestone Mar 4, 2015
@polikin
Copy link
Author

polikin commented Mar 4, 2015

cool, thanks!

@danielhickman
Copy link

Just thought I would add, when you drag the wave moves with you in Android (not waves, but Lollipop's effect) The orange box is to protect their phone number because the app never wanted to stay in the same position.
2015_03_10_20_26_09_1

@simonbbyrne
Copy link

This is actually quite confusing for a user when you are scrolling a list. Native user experience does not do this.
I was considering dealing with this, but the more i used the list in my app, the more annoying it became.

@lorensr
Copy link

lorensr commented Mar 16, 2015

Happening for me too, my use case is a list of checkboxes, and when I scroll down, the wave effect happens. Should only happen on tap/fastclick, not touchdown:

image

@fians
Copy link
Owner

fians commented Apr 12, 2015

@hoxxep has fix this issue. It solved on Windows Phone (IE), could someone check it on other phones like iOS and Android? Here is the preview: http://fian.my.id/Waves/v0.7.0-dev/

@hoxxep
Copy link
Contributor

hoxxep commented Apr 12, 2015

Works for me on iOS 8.

Also: apologies for being so stubbornly against the time delay on waves. I realise I was wrong and it still works well with the delay.

@Cosmitar
Copy link

Works on Android 4.1.2 browser Chrome v 41.0.2272.96

@polikin
Copy link
Author

polikin commented Apr 13, 2015

Works on Android 4.4 - Chrome v 41.0.2272.96

@fians
Copy link
Owner

fians commented Apr 13, 2015

I think it's enough. This will fixes will be bundled in v0.7.0 (currently in dev stage).

@fians fians closed this as completed Apr 13, 2015
@polikin
Copy link
Author

polikin commented Apr 13, 2015

Good job!

@simonbbyrne
Copy link

Fairplay, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants