Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store and send resourceVersion in watch_list/watcher #70

Closed
oyvindio opened this issue Oct 18, 2019 · 1 comment · Fixed by #124
Closed

Store and send resourceVersion in watch_list/watcher #70

oyvindio opened this issue Oct 18, 2019 · 1 comment · Fixed by #124
Labels
enhancement New functionality.

Comments

@oyvindio
Copy link
Member

The watch loop in Watcher should send the newest resourceVersion it has seen when restarting the watch connection to reduce pressure on the apiserver. See https://kubernetes.io/docs/reference/using-api/api-concepts/#efficient-detection-of-changes for suggested behavior.

This mechanism should probably be extended to support the watch bookmark feature (https://kubernetes.io/docs/reference/using-api/api-concepts/#watch-bookmarks) if available (since Kubernetes 1.16).
@oyvindio
Copy link
Member Author

Watch bookmark KEP: https://github.com/kubernetes/enhancements/blob/239b0c8cc09895b63151806251d7f6c2d2c3aa2f/keps/sig-api-machinery/20190206-watch-bookmark.md

@oyvindio oyvindio added the enhancement New functionality. label Oct 18, 2019
This was referenced Oct 1, 2020
Open
Closed
@oyvindio oyvindio mentioned this issue Jan 19, 2024
Merged
@oyvindio oyvindio linked a pull request Jan 19, 2024 that will close this issue
Lower the stream timeout to detect control plan rotation faster. #124
Merged
@perj perj closed this as completed in #124 Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Lower the stream timeout to detect control plan rotation faster. fiaas/k8s
2 participants
@oyvindio @mortenlj