RSpec has failing specs and is exiting with 0

[ethnt]

RSpec should not be exiting with code 0 if it has failing specs.

tardis:clock[master]$ be rspec spec
............................................F..

Failures:

  1) Marquee can be instantiated
     Failure/Error: marquee.should be_nil
       expected: nil
            got: #<Marquee _id: BSON::ObjectId('50a145949972772ba9000081'), text: "Foo to the bar.">
     # ./spec/unit/models/marquee_spec.rb:7:in `block (2 levels) in <top (required)>'

Finished in 5.39 seconds
47 examples, 1 failure

Failed examples:

rspec ./spec/unit/models/marquee_spec.rb:6 # Marquee can be instantiated

tardis:clock[master]$ echo $?
1

Without a DRb server running:

tardis:clock[master]$ be rspec spec
No DRb server is running. Running in local process instead ...
............................................F..

Failures:

  1) Marquee can be instantiated
     Failure/Error: marquee.should be_nil
       expected: nil
            got: #<Marquee _id: BSON::ObjectId('50a146159972772c4c000081'), text: "Foo to the bar.">
     # ./spec/unit/models/marquee_spec.rb:7:in `block (2 levels) in <top (required)>'

Finished in 5.15 seconds
47 examples, 1 failure

Failed examples:

rspec ./spec/unit/models/marquee_spec.rb:6 # Marquee can be instantiated
tardis:clock[master]$ echo $?
0

This is especially an issue in Travis, where it reports that a build has passed when it really hasn't (https://travis-ci.org/eturk/clock/jobs/3146542).

[ethnt]

This is a known issue with both RSpec and Spork. It is related to the --drb flag on RSpec.

• Exit code is always 0 when using --drb option when no drb server is running rspec/rspec-core#640
• rspec always return 1 when executed through DRb server rspec/rspec-core#641
• rspec always return 1 when executed through Spork on Windows sporkrb/spork#210
• Drb exit status rspec/rspec-core#335
• Fix --drb --failure-exit-code rspec/rspec-core#509