Combat Simulator Medals

[mthkltt]

This is something that has bugged me since the N64 days. When playing the Combat Simulator in single player you can't earn Accuracy or Head Shot medals. Make it so that these medals are awarded even if you're playing the Combat Simulator alone.

[jonaeru]

In the case of playing alone, the comparison would be with simulants.
Simulants probably does not keep track of Accuracy and Head Shots, so players need to compare with each other.
Those may need to be fixed.

https://github.com/fgsfdsfgs/perfect_dark/blob/port/src/game/mplayer/mplayer.c#L2338-L2435

[mthkltt]

In the case of playing alone, the comparison would be with simulants. Simulants probably does not keep track of Accuracy and Head Shots, so players need to compare with each other. Those may need to be fixed.

https://github.com/fgsfdsfgs/perfect_dark/blob/port/src/game/mplayer/mplayer.c#L2338-L2435

I did change it for myself and can get those medals now. You just need to change the condition for awarding Accuracy and Head Shot medals, from 2 or more players in the match to 1 or more players in the match. I just think it could be the default configuration, since nothing is lost by awarding those medals in single player Combat Simulator too. Other than that, getting Accuracy medals against Perfect and Dark Sims is very hard, but the Head Shot medal is fine.

[jonaeru]

	// Calculate Headshot and Accuracy medals
	if (!g_CheatsActiveBank0 && !g_CheatsActiveBank1 && numchrs >= 2) {

It seems like a good to fix numchrs >= 2.
The initial value of the comparison is 0.5, so you get the Accuracy medal for 51% or more.
The initial value of the comparison is 0, so you get the Head Shot medal for 1 or more headshots.
It certainly looks good.

[FrostKnight]

In the case of playing alone, the comparison would be with simulants. Simulants probably does not keep track of Accuracy and Head Shots, so players need to compare with each other. Those may need to be fixed.

https://github.com/fgsfdsfgs/perfect_dark/blob/port/src/game/mplayer/mplayer.c#L2338-L2435

I would love to be able to have accuracy and head shot medals come from battling ai as well as humans. If it weren't for that, I would have top rank on my n64. I am Near Perfect though at the moment. :P