Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of stored langstrings in database to support multilang #29

Open
1 of 3 tasks
adpe opened this issue Apr 21, 2020 · 0 comments
Open
1 of 3 tasks

Get rid of stored langstrings in database to support multilang #29

adpe opened this issue Apr 21, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@adpe
Copy link
Contributor

adpe commented Apr 21, 2020

Summary

Actual result

Expected result

Replication steps

Appendix

Hi @moleculech

I've just done a code review and correct some stuff. Did you also noticed, that it doesn't matter the configured language in the course or profile and the block always takes the German name for the langstring? I've found something here https://moodle.org/mod/forum/discuss.php?d=91157 and I asked in the Telegram Moodle dev chat:

image

image

I think we need to add more stuff here:

  • Disabled it per default in the global settings. As this is more FFHS-specific.
  • Add a setting with the available mod activities, so that the user can select which activities should be listed or not.
  • Add a setting with the available course categories or pattern e.g. Referenzkurse, so that the checker will only be displayed in this courses block.

Originally posted by @adpe in #19 (comment)

@adpe adpe added this to the Phase II milestone Apr 21, 2020
@adpe adpe added the bug Something isn't working label Apr 21, 2020
@adpe adpe added the enhancement New feature or request label Apr 29, 2020
@adpe adpe removed this from the Phase II milestone Apr 30, 2020
@adpe adpe removed the bug Something isn't working label May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant