Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Request to verify Feature) 'emptyWeekRowClass' is not working in 2.1.10 version. #315

Closed
RtzS opened this issue Jul 23, 2020 · 5 comments
Closed

(Request to verify Feature) 'emptyWeekRowClass' is not working in 2.1.10 version. #315

RtzS opened this issue Jul 23, 2020 · 5 comments

Comments

@RtzS
Copy link

RtzS commented Jul 23, 2020

Versions

Angular version: 7
component version: 2.1.10
Describe the bug

'emptyWeekRowClass' is not working in 2.1.10 version.
On click of clear button I don't want to close calendar. but calendar get closed.
Expected behavior
'emptyWeekRowClass' is not working in 2.1.10 version. I don't want to show next month date in Current month.

Screenshots
image

Thankyou in advance.
Any help will be appreciated
@RtzS
Copy link
Author

RtzS commented Aug 18, 2020

Can any one please check this issue.

@fetrarij
Copy link
Owner

fetrarij commented Sep 1, 2020

Hello. This is working well. However the class is added in the row section (tr) not the column one.
So the need you want may not emptyWeekRowClass.
Since I see this useful I am going to implement emptyWeekColumnClass.

fetrarij pushed a commit that referenced this issue Sep 1, 2020
Auto-generated commit -- feat(emptyWeekColumnClass): add emptyWeekCol…
062f8c4 
…umnClass attribute to add a custom class for all date in a week not in the current month

Fixes #315 #294 #126

Triggered by commit: ba1d136
Travis CI build: https://travis-ci.org/fetrarij/ngx-daterangepicker-material/builds/722968931
@RtzS
Copy link
Author

RtzS commented Sep 4, 2020

@fetrarij Still issue is not resolved. 'emptyWeekColumnClass' is not working with V2.1.10.

@fetrarij
Copy link
Owner

fetrarij commented Sep 4, 2020

@RtzS use v2.4.1

@RtzS
Copy link
Author

RtzS commented Sep 4, 2020

@fetrarij Thankyou for quick reply after changing version v2.1.10 to v2.4.1 able to access 'emptyWeekColumnClass', bit still I am facing some issues in hiding date in week which are not part of current month. PFA
image

Here I want to show date of current month only but it is not working as expected. It looks like gap.
Can you please suggest any solution.

Thankyou in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fetrarij @RtzS