Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add default error handler #176

Merged
merged 4 commits into from
Oct 5, 2023
Merged

Conversation

jrriehl
Copy link
Contributor

@jrriehl jrriehl commented Oct 4, 2023

  • Renames misnamed _handle_error function to _send_error_message
  • Adds a default error handler that can easily be overwritten if desired

A possible bonus is that rather than an empty protocol being default, the default protocol will now have something in it.

@jrriehl jrriehl requested a review from Archento October 4, 2023 16:30
Archento
Archento previously approved these changes Oct 5, 2023
Copy link
Member

@Archento Archento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from my one question this works perfectly as intended. Overwrite/rewrite of the internal handler is also easily possible.
Very happy with the quick solution :)

@jrriehl jrriehl merged commit d65668f into main Oct 5, 2023
8 checks passed
@jrriehl jrriehl deleted the feature/default-error-handler branch October 5, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants