Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of contracts with hyphens #219

Closed
jrriehl opened this issue Feb 21, 2023 · 0 comments · Fixed by #227
Closed

Fix handling of contracts with hyphens #219

jrriehl opened this issue Feb 21, 2023 · 0 comments · Fixed by #227
Labels
C-bug Category: Something isn't working

Comments

@jrriehl
Copy link
Contributor

jrriehl commented Feb 21, 2023

At the moment, Jenesis tries to assign these contracts to hyphenated variable names in the shell and scripts, which doesn't work because these are not valid Python names.

The easiest way forward is probably to replace - with _ when assigning the variable names.
@jrriehl jrriehl added the C-bug Category: Something isn't working label Feb 21, 2023
@jrriehl jrriehl linked a pull request Nov 6, 2023 that will close this issue
fix: replace hyphens with underscores in contract names #227
Merged
@jrriehl jrriehl closed this as completed Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: replace hyphens with underscores in contract names fetchai/jenesis
1 participant
@jrriehl