updated to send unmarshalled record with schema to kafka topic #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gurjit-sandhu
requested review from
bgilbert-fetchrewards,
mkravtsov-fetchrewards and
nrinaldi-fetch
| attributeValueStruct.put(attributeName, attributeValue.getBOOL()); | ||
| } | ||
| } | ||
| return attributeValueStruct; |
There was a problem hiding this comment.
should probably have an else? what if none of the else ifs match?
Also -> i'm sure you recognize the ugliness. Any better way?
There was a problem hiding this comment.
yep i will refactor some of this code once i make sure this is working with data in dev. will make it more cleaner and easy to read with comments
There was a problem hiding this comment.
I looked at the underlying AttributeValue.java. hideous code.
private String n; -> screw you!
to be clear, not gurjit's code.
bgilbert-fetchrewards
approved these changes
Sep 14, 2022
| attributeValueStruct.put(attributeName, attributeValue.getBOOL()); | ||
| } | ||
| } | ||
| return attributeValueStruct; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated to send unmarshalled record with schema to kafka topic and updated test cases