feat: support env vars in plugin urls (jdx#2370)

Author: roele

docs/dev-tools/aliases.md

@@ -26,3 +26,12 @@ echo "lts-fermium 14"
 Because this is mise-specific functionality not currently used by asdf it isn't likely to be in any
 plugin currently, but plugin authors can add this script without impacting asdf users.
 :::
+
+## Templates
+
+Alias values can be templates, see [Templates](/templates) for details.
+
+```toml
+[alias.node]
+current = "{{exec(command='node --version')}}"
+```

docs/plugins.md

@@ -46,3 +46,12 @@ any option and it will be passed to the plugin in that format.
 
 Currently this only supports simple strings, but we can make it compatible with more complex types
 (arrays, tables) fairly easily if there is a need for it.
+
+## Templates
+
+Plugin custom repository values can be templates, see [Templates](/templates) for details.
+
+```toml
+[plugins]
+my-plugin = "https://{{ get_env(name='GIT_USR', default='empty') }}:{{ get_env(name='GIT_PWD', default='empty') }}@github.com/foo/my-plugin.git"
+```

docs/templates.md

@@ -26,6 +26,13 @@ PROJECT_NAME = "{{config_root | split(pat='/') | last}}"
 Here's another using `exec()`:
 
 ```toml
-[aliases]
+[alias.node]
 current = "{{exec(command='node --version')}}"
 ```
+
+Or one that uses [`get_env()`](https://keats.github.io/tera/docs/#get-env):
+
+```toml
+[plugins]
+my-plugin = "https://{{ get_env(name='GIT_USR', default='empty') }}:{{ get_env(name='GIT_PWD', default='empty') }}@github.com/foo/my-plugin.git"
+```

src/cli/alias/ls.rs

@@ -27,7 +27,7 @@ pub struct AliasLs {
 
 impl AliasLs {
     pub fn run(self) -> Result<()> {
-        let config = Config::get();
+        let config = Config::try_get()?;
         let rows = config
             .get_all_aliases()
             .iter()

src/cli/alias/set.rs

@@ -20,7 +20,7 @@ pub struct AliasSet {
 
 impl AliasSet {
     pub fn run(self) -> Result<()> {
-        let mut global_config = Config::get().global_config()?;
+        let mut global_config = Config::try_get()?.global_config()?;
         global_config.set_alias(&self.plugin, &self.alias, &self.value)?;
         global_config.save()
     }

src/cli/alias/unset.rs

@@ -18,7 +18,7 @@ pub struct AliasUnset {
 
 impl AliasUnset {
     pub fn run(self) -> Result<()> {
-        let mut global_config = Config::get().global_config()?;
+        let mut global_config = Config::try_get()?.global_config()?;
         global_config.remove_alias(&self.plugin, &self.alias)?;
         global_config.save()
     }

src/config/config_file/mise_toml.rs

@@ -219,8 +219,15 @@ impl ConfigFile for MiseToml {
         }
     }
 
-    fn plugins(&self) -> HashMap<String, String> {
-        self.plugins.clone()
+    fn plugins(&self) -> eyre::Result<HashMap<String, String>> {
+        self.plugins
+            .clone()
+            .into_iter()
+            .map(|(k, v)| {
+                let v = self.parse_template(&v)?;
+                Ok((k, v))
+            })
+            .collect()
     }
 
     fn env_entries(&self) -> eyre::Result<Vec<EnvDirective>> {
@@ -324,8 +331,23 @@ impl ConfigFile for MiseToml {
         Ok(trs)
     }
 
-    fn aliases(&self) -> AliasMap {
-        self.alias.clone()
+    fn aliases(&self) -> eyre::Result<AliasMap> {
+        self.alias
+            .clone()
+            .iter()
+            .map(|(k, v)| {
+                let k = k.clone();
+                let v: Result<BTreeMap<String, String>, eyre::Error> = v
+                    .clone()
+                    .into_iter()
+                    .map(|(k, v)| {
+                        let v = self.parse_template(&v)?;
+                        Ok((k, v))
+                    })
+                    .collect();
+                v.map(|v| (k, v))
+            })
+            .collect()
     }
 
     fn task_config(&self) -> &TaskConfig {
@@ -878,7 +900,7 @@ mod tests {
         let cf = MiseToml::from_file(&dirs::HOME.join("fixtures/.mise.toml")).unwrap();
 
         assert_debug_snapshot!(cf.env_entries().unwrap());
-        assert_debug_snapshot!(cf.plugins());
+        assert_debug_snapshot!(cf.plugins().unwrap());
         assert_snapshot!(replace_path(&format!(
             "{:#?}",
             cf.to_tool_request_set().unwrap()

src/config/config_file/mod.rs

@@ -60,8 +60,8 @@ pub trait ConfigFile: Debug + Send + Sync {
             None => None,
         }
     }
-    fn plugins(&self) -> HashMap<String, String> {
-        Default::default()
+    fn plugins(&self) -> eyre::Result<HashMap<String, String>> {
+        Ok(Default::default())
     }
     fn env_entries(&self) -> eyre::Result<Vec<EnvDirective>> {
         Ok(Default::default())
@@ -77,8 +77,8 @@ pub trait ConfigFile: Debug + Send + Sync {
         Ok(self.to_tool_request_set()?.into())
     }
     fn to_tool_request_set(&self) -> eyre::Result<ToolRequestSet>;
-    fn aliases(&self) -> AliasMap {
-        Default::default()
+    fn aliases(&self) -> eyre::Result<AliasMap> {
+        Ok(Default::default())
     }
     fn task_config(&self) -> &TaskConfig {
         static DEFAULT_TASK_CONFIG: Lazy<TaskConfig> = Lazy::new(TaskConfig::default);

src/config/mod.rs

@@ -77,13 +77,11 @@ impl Config {
         let config_paths = load_config_paths(&config_filenames);
         let config_files = load_all_config_files(&config_paths, &legacy_files)?;
 
-        let repo_urls = config_files.values().flat_map(|cf| cf.plugins()).collect();
-
         let config = Self {
-            aliases: load_aliases(&config_files),
+            aliases: load_aliases(&config_files)?,
             project_root: get_project_root(&config_files),
+            repo_urls: load_plugins(&config_files)?,
             config_files,
-            repo_urls,
             ..Default::default()
         };
 
@@ -603,18 +601,28 @@ fn parse_config_file(
     }
 }
 
-fn load_aliases(config_files: &ConfigMap) -> AliasMap {
+fn load_aliases(config_files: &ConfigMap) -> Result<AliasMap> {
     let mut aliases: AliasMap = AliasMap::new();
 
     for config_file in config_files.values() {
-        for (plugin, plugin_aliases) in config_file.aliases() {
+        for (plugin, plugin_aliases) in config_file.aliases()? {
             for (from, to) in plugin_aliases {
                 aliases.entry(plugin.clone()).or_default().insert(from, to);
             }
         }
     }
 
-    aliases
+    Ok(aliases)
+}
+
+fn load_plugins(config_files: &ConfigMap) -> Result<HashMap<String, String>> {
+    let mut plugins = HashMap::new();
+    for config_file in config_files.values() {
+        for (plugin, url) in config_file.plugins()? {
+            plugins.insert(plugin.clone(), url.clone());
+        }
+    }
+    Ok(plugins)
 }
 
 impl Debug for Config {