Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull authors from commit history? #12

Open
hackergrrl opened this issue Feb 9, 2018 · 5 comments
Open

Pull authors from commit history? #12

hackergrrl opened this issue Feb 9, 2018 · 5 comments

Comments

@hackergrrl
Copy link

This is more involved, but it'd be cool if all contributors to a project got pulled in as well as the last npm publisher!

@feross
Copy link
Owner

feross commented Feb 9, 2018

@noffle It's not just looking up the last npm publisher. It's looking up everyone who had npm publish permission at the time of the last release.

As a concrete example, take a look at the response from http://registry.npmjs.com/standard/latest at the "maintainers" key. That's what we're using.

I wonder what the tradeoffs of using git history vs. npm publisher history are. Seems like you'd pull in more casual contributors which could be good. But I wonder if folks would game this by just getting in trivial things like copyright year updates into popular projects so they can show up as a suggestion in thanks. Any other tradeoffs you can think of?

@styfle
Copy link

styfle commented Feb 9, 2018

But I wonder if folks would game this by just getting in trivial things like copyright year updates into popular projects

Hey I do this but I'm not trying to game the system...

It's just that a lot of projects have typos in their docs 😃

Forked repos in December

history

That being said, I probably should not receive donations for adding a couple lines to the docs.
But I still "claim" to be a node contributor hehe 😉

@hackergrrl
Copy link
Author

This is going into bigger scope, but this project feels like it's on the same spectrum as @kemitchell's License Zero and sustain. I think sustain's ability to create a weighted hierarchy of payments is particularly powerful: level of contribution can be represented. It's all about answering the extremely important question: "how do free software devs get paid?"

@hackergrrl
Copy link
Author

hackergrrl commented Feb 9, 2018

There's something really powerful and magical about saying "give $10 to my dependencies" and have that money actually trickle down to those authors & contributors all the way down. (In theory!)

thanks has the clean simple interface & the right intentions -- seems like a great vector for this kind of thing!

@giuseppeg
Copy link

giuseppeg commented Feb 10, 2018

what about defining a custom thanks array of authors usernames in package.json (instead of authors putting their name in your repo via PR - it'd scale better)?

edit: sorry i didn't see #2 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants