-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
add "Node v4 or greater is required" message
- v17.1.2
- v17.1.1
- v17.1.0
- v17.0.0
- v17.0.0-2
- v17.0.0-1
- v17.0.0-0
- v16.0.4
- v16.0.3
- v16.0.2
- v16.0.1
- v16.0.0
- v15.0.1
- v15.0.0
- v14.3.4
- v14.3.2
- v14.3.1
- v14.3.0
- v14.2.0
- v14.1.0
- v14.0.2
- v14.0.1
- v14.0.0
- v14.0.0-1
- v14.0.0-0
- v13.1.0
- v13.0.2
- v13.0.1
- v13.0.0
- v13.0.0-0
- v12.0.1
- v12.0.0
- v11.0.1
- v11.0.0
- v11.0.0-beta.0
- v10.0.3
- v10.0.2
- v10.0.1
- v10.0.0
- v10.0.0-beta.2
- v10.0.0-beta.1
- v10.0.0-beta.0
- v9.0.2
- v9.0.1
- v9.0.0
- v9.0.0-beta.0
- v8.6.0
- v8.5.0
- v8.4.0
- v8.3.0
- v8.2.0
- v8.1.0
- v8.0.0
- v8.0.0-beta.5
Showing
1 changed file
with
7 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,9 @@ | ||
#!/usr/bin/env node | ||
|
||
var opts = require('../options') | ||
require('standard-engine').cli(opts) | ||
if (process.version.match(/v(\d+)\./)[1] < 4) { | ||
console.error('standard: Node v4 or greater is required. `standard` did not run.') | ||
} else { | ||
var opts = require('../options') | ||
require('standard-engine').cli(opts) | ||
} | ||
|
85e19d6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is v4 needed? i use standard but on plenty on modules that support 0.12, 0.10, kinda annoying that i have to pin an old version now.
85e19d6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i guess this is related to http://eslint.org/docs/user-guide/migrating-to-3.0.0
85e19d6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, eslint 3.0 decided to drop support for Node <4.x which introduced that restriction here as well...
85e19d6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'm not a fan of folks aggressively dropping Node 0.10 and 0.12 support either, but this came from ESLint. We enabled a bunch of bug-catching new rules in
standard
v8, so I think it's a net win.Also, you can keep 0.10 and 0.12 in your Travis tests, because
standard
will pass on those versions, without running. 👍