Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output Run Stats #6

Open
4 of 6 tasks
beauremus opened this issue Jun 23, 2020 · 8 comments
Open
4 of 6 tasks

Output Run Stats #6

beauremus opened this issue Jun 23, 2020 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@beauremus
Copy link
Member

beauremus commented Jun 23, 2020

We should provide stats on each run for troubleshooting purposes. These don't need to be versioned so we included them in the .gitignore. I think we should output the stats of each run to a file named by its date-time. We should also have a cleanup function that only allows a week of stats to persist.

Things to time:

  • DPM data acquisition
  • HDF file output

Things to log:

  • DAQ errors
  • Python errors
  • Debug log
  • Empty DAQ for any device
@beauremus beauremus added the enhancement New feature or request label Jun 23, 2020
@beauremus
Copy link
Member Author

Edited the OP to include "Things to log."

@beauremus
Copy link
Member Author

Edited the OP to include "Empty DAQ" in "Things to log."

@beauremus
Copy link
Member Author

Let's focus on stats gathering first and we can worry about maintenance and cleanup later.

@beauremus
Copy link
Member Author

beauremus commented Feb 22, 2021

Python errors and debug log issues are solved because cronjobs output to mail /var/log/mail/gmpsai-prod.

@beauremus
Copy link
Member Author

Concerning "Empty DAQ for any device":
I think the only way to determine that a device has no data is to compare the list of devices in the device request input file with the keys in the .h5 output file.
A key is only added to the h5 file in the case where data is returned. If the key isn't present in the h5 file then no data was received for that device.

There's another step after this to determine why the key isn't in the h5 file. If a status comes through for a device, it will not be in the list of keys. The status should be evaluated instead of assuming no data.

If there is no key in the h5 file and there is no related status, then no data is available for that request. Otherwise, the error is reported and should be evaluated or understood.

@sakshi-fermi
Copy link
Contributor

Estimated time for logging:

Best case: 1 day

Best guess: 2-3 days

Worst case: 5 days

@sakshi-fermi
Copy link
Contributor

Python errors and debug log issues are solved because cronjobs output to mail /var/log/mail/gmpsai-prod.

These were not logged in /var/log/mail/gmpsai-prod after Feb 12 because of an unknown issue but will be logged in a separate log file

@sakshi-fermi
Copy link
Contributor

Things to log
This is addressed by e7939d2 2ff31c0 eb660df .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants