-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SSL support #42
Comments
If this post can be believed this is a one-line change after importing the SSL module. This would be a good first issue. |
I'll take it, please! |
Thanks for volunteering, @potap75 ! |
What should I use as an upstream master? v1.0.0rc6 ? |
Yes. That's correct. |
thank you! |
I keep getting: "fatal: branch 'master' does not exist" |
When I'm trying to setup a branch in PyCharm: git branch --set-upstream-to=upstream/v1.0.0rc6 |
Yes. Branch master doesn't exist. The branches are labeled by major version so you want |
Strange. We set |
Anyways. Maybe I can contribute directly here: import socket
import ssl
hostname = ''
context = ssl.create_default_context()
with socket.create_connection((hostname, 443)) as sock:
with context.wrap_socket(sock, server_hostname=hostname) as ssock:
print(ssock.version()) EDIT: Code highlighting |
Thank you for the contribution, @potap75. We're using the UPDATE: It looks like we can do something like this: con_fut = loop.create_connection(lambda: self,
host='acsys-proxy.fnal.gov',
port=self.port,
ssl=True) |
e56b8d6 is the proposed change. We're getting sslv3 handshake errors but, when I point the Python script to a non-DPM SSL server, this code connects. So @charlieking65 and I think it's a config issue on the proxy. |
Here's an HTTPS implementation that seems like it could be useful for our socket communications.
https://chaobin.github.io/2015/07/22/a-working-understanding-on-SSL-and-HTTPS-using-python/
The text was updated successfully, but these errors were encountered: