Skip to content

update based on feedback #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fengzhou-msft merged 2 commits into from
Jun 21, 2021
Merged

update based on feedback #1

fengzhou-msft merged 2 commits into from
Jun 21, 2021

Conversation

@00Kai0
Copy link
Collaborator

@00Kai0 00Kai0 commented Jun 15, 2021

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

@00Kai0 00Kai0 requested a review from fengzhou-msft as a code owner June 15, 2021 09:22
@fengzhou-msft fengzhou-msft merged commit 76851d7 into fengzhou-msft:confluent_improvement Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fengzhou-msft fengzhou-msft fengzhou-msft approved these changes

+1 more reviewer

@jsntcy jsntcy jsntcy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@00Kai0 @jsntcy @fengzhou-msft