-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
日志信息缺少关键的错误地址信息 #54
Labels
Comments
恩 已在日志中增加 请求主机地址的记录, 近期会提交代码 |
感谢 |
fengjiachun
pushed a commit
that referenced
this issue
Feb 7, 2018
fengjiachun
pushed a commit
that referenced
this issue
Feb 7, 2018
@uvletter done |
现在的代码已经OK,不过failover不支持多播,那dispatch返回的必然是DefaultInvokeFuture,所以那一次类型判断是多余的。原谅我的代码洁癖orz |
不过以后对InvokeFuture接口可能有新的实现类,你这个处理没问题。 |
@uvletter 类型判断就是个防御性质, 避免未来Future这块有改动导致这里出现了cast异常 |
fengjiachun
pushed a commit
that referenced
this issue
Apr 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
建议在failover策略的错误日志中加上对请求主机地址的记录,方便在生产环境下快速排查和恢复错误。
dubbo的记录信息如下,我觉得是比较合理的。
The text was updated successfully, but these errors were encountered: