Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing custom CSS to terminal #13

Closed
moigagoo opened this issue Apr 17, 2018 · 6 comments
Closed

Allow passing custom CSS to terminal #13

moigagoo opened this issue Apr 17, 2018 · 6 comments

Comments

@moigagoo
Copy link

One of huge benefits of XTerm.js is that you can use CSS to customize the output. It would be great to be able to customize the styles for themes in FluentTerminal.

For example, here's how Hyper—another XTerm.js-based terminal emulator—allows you to enable ligatures: vercel/hyper#874

@moigagoo moigagoo changed the title Allow pasasing custom CSS to terminal Allow passing custom CSS to terminal Apr 17, 2018
@felixse
Copy link
Owner

felixse commented Apr 17, 2018

Good idea, I will add this for the next release

@felixse
Copy link
Owner

felixse commented Apr 22, 2018

Keep in mind that ligatures are not supported by xterm.js: xtermjs/xterm.js#958

@moigagoo
Copy link
Author

Hmm, weird, I could swear I successfully enabled ligatures in hyper, at least in some older version. Apparently, things got broken since then.

@felixse
Copy link
Owner

felixse commented Apr 22, 2018

Do you see any further need for passing custom css now that xterm.js is basically a giant canvas? I don't think there is much to gain from it right now, but if someone finds a case I will add the feature.

@moigagoo
Copy link
Author

moigagoo commented Apr 22, 2018

Do you see any further need for passing custom css now that xterm.js is basically a giant canvas?

For me, it was just the ligatures.

I don't think there is much to gain from it right now,

Yep, I agree.

@felixse
Copy link
Owner

felixse commented May 23, 2018

I am going to close this now. If someone has a case for custom css feel free to write here, then I will reopen this.

@felixse felixse closed this as completed May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants