Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish CommonJS dist files #12

Open
sqs opened this issue Dec 17, 2018 · 0 comments
Open

Publish CommonJS dist files #12

sqs opened this issue Dec 17, 2018 · 0 comments

Comments

@sqs
Copy link

sqs commented Dec 17, 2018

Because this package only publishes/distributes ES6 modules, tooling that expects all node_modules/**/*.js files to be CommonJS modules will break. There are simple workarounds for this issue (see https://github.com/sourcegraph/sourcegraph/pull/1456#discussion_r241994980), so this is not high priority.

(Related issue for lodash-es: facebook/create-react-app#5241 (comment))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sqs