Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree | icepick fails #29

Open
Byron opened this issue Feb 25, 2015 · 2 comments
Open

tree | icepick fails #29

Byron opened this issue Feb 25, 2015 · 2 comments

Comments

@Byron
Copy link

Byron commented Feb 25, 2015

Maybe it's not even supposed to work, yet I thought I should let you know anyway.

tree | icepick

output

@felipesere
Copy link
Owner

This is due to the way we iterate through the strings. I have a branch the iterates using chars(), but there is a performance penalty.
I'll push the branch so you can see if it solves the issue.

@Byron
Copy link
Author

Byron commented Feb 25, 2015

When compiling the unicode_regression branch, the example above works for me.

Considering that we are in Rust, the performance penalty might be preferred over the crash above. It's probably still fast enough for common usage scenarios.

After all, first it should work right, before one can spend additional time to make it work fast.

It's a nice tool by the way, previously I used tree | less, which is somewhat inferior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants